Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix block disposal animations #7948

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Conversation

gonfunko
Copy link
Contributor

The basics

The details

Proposed Changes

This PR addresses several issues with the block deletion animation:

  • When the workspace is at a scale other than 1.0, the animation is offset (or invisible) from the location of the block being deleted when deleting a block by dragging it to the toolbox
  • The deletion animation is obscured by the toolbox, so that only that portion of the block within the workspace bounds when the block is dropped in the toolbox has its animation visible, even though the whole block was visible atop the toolbox when the drag was ongoing

Reason for Changes

These changes make the deletion animation when disposing of a block into the toolbox smoother and more natural.

Note that there is still some offsetting when the workspace is zoomed out, a block is dragged in, the workspace is zoomed in, and the block is disposed of into the toolbox. I'm sending this PR now because it's a strict improvement on the current state of affairs, and that issue is pretty edge-casey.

@gonfunko gonfunko requested a review from a team as a code owner March 18, 2024 22:32
@gonfunko gonfunko requested a review from maribethb March 18, 2024 22:32
@github-actions github-actions bot added the PR: fix Fixes a bug label Mar 18, 2024
@gonfunko gonfunko merged commit 199c00a into google:develop Mar 19, 2024
6 checks passed
@gonfunko gonfunko deleted the delete-animation branch March 19, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants