Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing libbrotlidec-static.a in version 1.1.0 #1174

Open
moravveji opened this issue Jun 7, 2024 · 1 comment
Open

Missing libbrotlidec-static.a in version 1.1.0 #1174

moravveji opened this issue Jun 7, 2024 · 1 comment

Comments

@moravveji
Copy link

I am building the Brunsli/0.1-GCCcore-13.2.0 module from source on our HPC clusters, and it depends on libbrotlidec-static.a. The latter static library is automatically created with Brotli version 1.0.9. However, in the newer minor release 1.1.0, the static library is no longer created.

This is causing a lot of dependency resolution issues for me when building massive bundle of R packages using EasyBuild (see e.g. (this PR)[https://github.com/easybuilders/easybuild-easyconfigs/pull/20756]).

Now, I wonder how it would be possible to let the build system for version 1.1.0 consistently create libbrotlidec-static.a, so that I can compile my desired version of Brunsli by linking to it.

@moravveji
Copy link
Author

moravveji commented Jun 12, 2024

When I diff the CMakeLists.txt between version 1.0.9 and 1.1.0, I see that the following directives are removed, resulting in not building libbrotli{dec,enc,common}-static.a.

set(BROTLI_LIBRARIES_CORE_STATIC brotlienc-static brotlidec-static brotlicommon-static)
set(BROTLI_STATIC_LIBS brotlicommon-static brotlidec-static brotlienc-static)
add_library(brotlicommon-static STATIC ${BROTLI_COMMON_C})
add_library(brotlidec-static STATIC ${BROTLI_DEC_C})
add_library(brotlienc-static STATIC ${BROTLI_ENC_C})
target_link_libraries(brotlidec-static brotlicommon-static)
target_link_libraries(brotlienc-static brotlicommon-static)

I wonder why this has happened?
Also, I am thinking of patching version 1.1.0 to restore building the *-static.a libraries. Is that fine?

ryandesign referenced this issue in macports/macports-ports Aug 4, 2024
As of brotli 1.1.0, upstream no longer builds static libraries by
default. Although there are no dependents in the ports tree requiring
the static libraries, users have asked for these.

As the build system only allows to build static or shared libaries in
one run, create a separate subport that installs the static libraries
only.
chipitsine added a commit to chipitsine/wal-g that referenced this issue Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant