-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Distances field to machine.Node #3179
Conversation
Signed-off-by: PiotrProkop <[email protected]>
Hi @PiotrProkop. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you extend the metrics?
https://github.com/google/cadvisor/blob/master/metrics/prometheus_machine.go#L156
And describe the new one in the docs?
https://github.com/google/cadvisor/blob/master/docs/storage/prometheus.md#prometheus-hardware-metrics
Signed-off-by: PiotrProkop <[email protected]>
@Creatone thanks for review, metrics updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit and it can be merged 👍
Signed-off-by: PiotrProkop <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add information about NUMA distances to Node struct.