Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc to note a hostnetwork pods' metrics known behavior #3316

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JamesRaynor67
Copy link

#2615 mentioned a WAI cAdvisor behavior for pods with hostNetwork: true.

It should be mentioned in doc to avoid people spending days to do test and searching and then finally find it in issue list.

google#2615 mentioned a WAI cAdvisor behavior for pods with `hostNetwork: true`.

It should be mentioned in doc to avoid people spending days to do test and searching and then finally find it in issue list.
@k8s-ci-robot
Copy link
Collaborator

Hi @JamesRaynor67. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -98,6 +98,8 @@ Metric name | Type | Description | Unit (where applicable) | option parameter |
`container_threads_max` | Gauge | Maximum number of threads allowed inside the container | | process |
`container_ulimits_soft` | Gauge | Soft ulimit values for the container root process. Unlimited if -1, except priority and nice | | process |

* `*`This metrics can be misleading for pod with `hostNetwork: true` ([Details](https://github.com/google/cadvisor/issues/2615)).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use footnote notation instead?

@iwankgb
Copy link
Collaborator

iwankgb commented Jun 27, 2023

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants