Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysfs: trim spaces in device hidden check #3522

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

clwluvw
Copy link
Contributor

@clwluvw clwluvw commented Apr 24, 2024

The hidden file might have an endline, so the check for equals to 1 would not be true. Trimming the spaces would help to cover this case.

Copy link

google-cla bot commented Apr 24, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@k8s-ci-robot
Copy link
Collaborator

Hi @clwluvw. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

The hidden file might have an endline, so the check for equals to 1 would not be true.
Trimming the spaces would help to cover this case.

Signed-off-by: Seena Fallah <[email protected]>
@iwankgb
Copy link
Collaborator

iwankgb commented Apr 27, 2024

/ok-to-test

@clwluvw
Copy link
Contributor Author

clwluvw commented May 24, 2024

/retest

@clwluvw
Copy link
Contributor Author

clwluvw commented Oct 3, 2024

Hi @iwankgb - Can you please help here with why the CI is not happy?

@iwankgb iwankgb closed this Oct 4, 2024
@iwankgb iwankgb reopened this Oct 4, 2024
@iwankgb iwankgb merged commit 96c346e into google:master Oct 4, 2024
20 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants