ext: add list.sort() #1021
Merged
ext: add list.sort() #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
/gcbrun |
cezar-guimaraes
force-pushed
the
list-sort
branch
from
2ff4703
to
802efa8
Compare
|
/gcbrun |
|
@cezar-guimaraes I just had one more comment, but otherwise this is looking good. |
|
/gcbrun |
cezar-guimaraes
force-pushed
the
list-sort
branch
2 times, most recently
from
eb55f76
to
50e5a97
Compare
cezar-guimaraes
force-pushed
the
list-sort
branch
from
50e5a97
to
be89068
Compare
|
/gcbrun |
TristonianJones
approved these changes
Sep 23, 2024
|
@cezar-guimaraes thanks for your contribution and your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I skipped creating an issue because this seemed like a small enough change to me, but please let me know if an issue is preferable.
This PR adds a
<list(T)>.sort() -> <list(T)>member. T must implement(traits.Comparer).I believe that the check if the element type implements
traits.Compareronly happens at runtime (how can I write tests for this?). An alternative implementation would create separate member overloads forlist(T), T in {set of comparable types}similar to kube apiserver list extensionsLet me know if I should update the PR to create separate overloads.