Ensure that proto reflection falls back to dynamic lookup #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scriptors are not shared by CEL and the proto
JimLarson
approved these changes
Feb 10, 2021
common/types/pb/type.go
Outdated
| pbDesc := pbRef.Descriptor() | ||
| if pbDesc == fd.desc.ContainingMessage() { | ||
| // When the target protobuf shares the same message descriptor instance as the field | ||
| // descriptoruse the cached field descriptor value. |
There was a problem hiding this comment.
"descriptoruse" -> "descriptor, use"
TristonianJones
force-pushed
the
dyn-pb-fallback
branch
from
58f880a
to
3ad1e91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When proto descriptors are not shared by CEL and an input proto message, make sure that the
GetFromandIsSettests fallback to dynamicFieldDescriptorlookups rather than using cached values.