Return errors when duration or timestamp overflow is detected #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe I need to address time zones in overflow detection, so please hold till I can verify. |
|
/gcbrun |
TristonianJones
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duration evaluation, if arithmetic on duration or timestamp causes overflow return an error. Additionally this pull request enables the timestamp and duration conformance tests and implements the functionality in the conformance server.
Timestamp range is defined per
google.protobuf.Timestampto be the range0001-01-01T00:00:00Zto9999-12-31T23:59:59.999999999Z.