Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate macro calls #455

Merged
merged 10 commits into from
Oct 6, 2021
Merged

Populate macro calls #455

merged 10 commits into from
Oct 6, 2021

Commits on Sep 9, 2021

  1. Update parser options with flag populateMacroCalls. When set to true,… 

    … all macro replacements will be stored in sourceInfo.MacroCalls
    @ZachSierp
    ZachSierp committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    a8c3a2e View commit details
    Browse the repository at this point in the history

  2. Add macro calls to sourceImpl

    @ZachSierp
    ZachSierp committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    24f2493 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2021

  1. Merge branch 'google:master' into populate-macro-calls

    @ZachSierp
    ZachSierp authored Sep 29, 2021
    Configuration menu
    Copy the full SHA
    5b6fe4f View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. Add functions to populate the macro calls map when parsing macros. Ne… 

    …sted macros, macros as targets, and nested macro args should all be stored as a simple ID for lookup in the macro calls table.
    @ZachSierp
    ZachSierp committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    99b79bf View commit details
    Browse the repository at this point in the history

  2. Add test cases for macro calls implementation

    @ZachSierp
    ZachSierp committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    9fb02a2 View commit details
    Browse the repository at this point in the history

  3. Remove debug prints and document the macro calls test helper function.

    @ZachSierp
    ZachSierp committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    acfe7ed View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. Improve performance by allocating an exactly sized array instead of a… 

    …ppending. Simplify creating expressions and use accessor functions instead of accessing fields directly.
    @ZachSierp
    ZachSierp committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    c2513ef View commit details
    Browse the repository at this point in the history

  2. Add comment for PopulateMacroCalls function

    @ZachSierp
    ZachSierp committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    8be4cbd View commit details
    Browse the repository at this point in the history

  3. Use accessor methods instead of direct field access

    @ZachSierp
    ZachSierp committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    ff4f023 View commit details
    Browse the repository at this point in the history

  4. Update DiffMessage to use pattern.

    @ZachSierp
    ZachSierp committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    2c81d50 View commit details
    Browse the repository at this point in the history