Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext: Rename go_strings_library target to go_default_library #457

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

martinxsliu
Copy link
Contributor

Hi team, this PR renames the //ext:go_strings_library Bazel target to //ext:go_default_library. If we are concerned about backwards compatibility, we alternatively add an alias rule instead.

The go_default_library target name is the default name generated by Gazelle and is also the name used by all other go_library targets in this package. Other than being conventional, this custom named target makes using the ext package transitively by other packages (example) difficult. This is because Gazelle generates deps that assume the go_default_library target name, so to work around this we would need to supply a patch file for this repository that adds an alias in.

@TristonianJones
Copy link
Collaborator

/gcbrun

@TristonianJones TristonianJones merged commit 92119b8 into google:master Oct 12, 2021
@TristonianJones
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants