ext: Rename go_strings_library target to go_default_library #457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team, this PR renames the
//ext:go_strings_library
Bazel target to//ext:go_default_library
. If we are concerned about backwards compatibility, we alternatively add analias
rule instead.The
go_default_library
target name is the default name generated by Gazelle and is also the name used by all othergo_library
targets in this package. Other than being conventional, this custom named target makes using theext
package transitively by other packages (example) difficult. This is because Gazelle generates deps that assume thego_default_library
target name, so to work around this we would need to supply a patch file for this repository that adds an alias in.