New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes for type-santization and abstract types. #460

Merged

TristonianJones merged 1 commit into google:master from TristonianJones:type-checker-fixes

Oct 19, 2021

Collaborator

TristonianJones commented Oct 14, 2021

In an attempt to boost the coverage for the checker and parser related packages, a couple of bugs were uncovered:

Abstract types were not properly identified as such in the checker.
Type-sanitization which renames well-known protobuf names to their CEL equivalents was not actually performing the necessary scrubbing.

Both issues have been fixed with tests added and as-needed, also simplified.


          Bug fixes for type-santization and abstract types.

bc453a6

TristonianJones requested a review from jcking

October 14, 2021 23:51

TristonianJones mentioned this pull request

Ability to overwrite logical operations (&&, ||) #461

Closed

jcking approved these changes

View reviewed changes

TristonianJones merged commit 5cd4381 into google:master

TristonianJones deleted the type-checker-fixes branch

October 19, 2021 21:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet