Add option to compile regex constants at program creation time #497

jpbetz · 2022-02-26T02:42:04Z

This provides a program option to inject an optimization (by way of a Interpretable factory) for any regex function.

A matches optimization is provided and enabled when OptOptimize is set.

unoptimized matches:

BenchmarkInterpreter/matches
BenchmarkInterpreter/matches-8  165296	      7135 ns/op	    5845 B/op

optimized matches:

BenchmarkInterpreter/matches
BenchmarkInterpreter/matches-8  898917	      1413 ns/op	     210 B/op

jpbetz · 2022-02-26T02:42:14Z

cc @TristonianJones @liggitt

jpbetz · 2022-02-26T02:46:14Z

@TristonianJones I wasn't sure what API changes were best here. I'm open to suggestions alternatives to the RegexPatternArg functions.Override field and the CompiledRegexStringConst interface.

Possible alternatives would be to have RegexPatternArg accept an enumeration of options instead of an *int (the regex pattern is always the 1st argument in all the usages I'm aware of).

Possible alternatives to CompiledRegexStringConst would be a trait.

interpreter/functions/functions.go

interpreter/decorators.go

cel/cel_test.go

interpreter/interpreter.go

interpreter/interpreter_test.go

interpreter/interpretable.go

interpreter/optimizations.go

jpbetz force-pushed the regex-pre-compile branch from 634c059 to f26f87e Compare February 26, 2022 02:42

jpbetz requested a review from TristonianJones February 26, 2022 02:43

jpbetz force-pushed the regex-pre-compile branch 2 times, most recently from 79677b1 to 230c5df Compare February 26, 2022 04:01

TristonianJones reviewed Feb 28, 2022

View reviewed changes

interpreter/functions/functions.go Outdated Show resolved Hide resolved

interpreter/decorators.go Outdated Show resolved Hide resolved

jpbetz force-pushed the regex-pre-compile branch 2 times, most recently from ce28037 to cabcdb8 Compare February 28, 2022 23:50