Update types.Unknown with attribute trails #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @josephschorr |
jnthntatum
requested changes
Jul 12, 2023
Additional test cases provided for unknown string formatting as well as for handling unknown field selections across numeric types. This change also revealed an issues with how custom attribute factorie qualifiers were not being tracked correctly during state-tracking, nor was the type information correctly collected for array index operations.
TristonianJones
force-pushed
the
useful-unknown
branch
from
d54183c
to
015ff68
Compare
|
@jnthntatum PTAL, thanks! |
jnthntatum
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the types.Unknown definition.
Breaking change
Use
*types.Unknownrather thantypes.Unknownduringtype casting as the underlying type has changed from a slice
to a structured object.
Specifically, shift
types.Unknownfrom a simple list of intsto a structured object which contains the set of unknown
expression ids, as well as the attribute trails associated with
each.
In the future this object may be further augmented with
information about missing function invocations.
Closes #771