Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve token representation in AST #932

Merged
merged 1 commit into from
May 1, 2024

Conversation

kortschak
Copy link
Contributor

This change includes vendor directory addition of go-cmp. Unfortunately the go-cmp checks require an end-run around test package hermeticity, but I have made this as minimal as possible.

Please take a look.

Pull Requests Guidelines

See CONTRIBUTING.md for more details about when to create
a GitHub Pull Request and when other kinds of contributions or
consultation might be more desirable.

When creating a new pull request, please fork the repo and work within a
development branch.

Commit Messages

  • Most changes should be accompanied by tests.
  • Commit messages should explain why the changes were made.
Summary of change in 50 characters or less

Background on why the change is being made with additional detail on
consequences of the changes elsewhere in the code or to the general
functionality of the library. Multiple paragraphs may be used, but
please keep lines to 72 characters or less.

Reviews

  • Perform a self-review.
  • Make sure the Travis CI build passes.
  • Assign a reviewer once both the above have been completed.

Merging

  • If a CEL maintaner approves the change, it may be merged by the author if
    they have write access. Otherwise, the change will be merged by a maintainer.
  • Multiple commits should be squashed before merging.
  • Please append the line closes #<issue-num>: description in the merge message,
    if applicable.

@TristonianJones
Copy link
Collaborator

/gcbrun

@kortschak
Copy link
Contributor Author

Fixed vendoring issue.

@TristonianJones
Copy link
Collaborator

/gcbrun

@TristonianJones TristonianJones self-requested a review April 25, 2024 18:59
Previously the AST did not hold the token's source end offset in many
cases. This change adds token end offset by offsetting the end by the text
length from the token start.
@TristonianJones
Copy link
Collaborator

/gcbrun

@TristonianJones TristonianJones merged commit bf934ab into google:master May 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants