Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

bump intl version to 0.18.0 #598

Closed
wants to merge 3 commits into from
Closed

Conversation

ArtyomSasin
Copy link
Contributor

intl: ">=0.15.2 < 0.18.0"

@google-cla
Copy link

google-cla bot commented Mar 3, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Mar 3, 2021
@ArtyomSasin
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Mar 3, 2021
@itsbalamurali
Copy link

@mit-mit @nshahan approve, please.

Copy link

@babulpatel1309 babulpatel1309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Urgent => Needs to be merged ASAP

@rafaelcmm
Copy link

This needs to be merged ASAP

@cedricDevWP
Copy link

Up

@cedricDevWP
Copy link

I'm still worried ... a new version will be available?

@tony123S
Copy link

tony123S commented Mar 5, 2021

please fix it asap :)

@tony123S
Copy link

tony123S commented Mar 5, 2021

@mit-mit @nshahan

@kevlar700
Copy link

#566
#582
#587

@babulpatel1309
Copy link

babulpatel1309 commented Mar 5, 2021

@googlebot I've signed it!

@hdavidmb
Copy link

hdavidmb commented Mar 5, 2021

Also waiting for this package to be updated asap.

Copy link

@frankyvij frankyvij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArtyomSasin
Copy link
Contributor Author

@nshahan approve, please

@connlaoi
Copy link

connlaoi commented Mar 5, 2021

@lorrainekan @mit-mit @nshahan @cbbraun

Can we please see some movement here, the community has already resolved this and just needs one of you to finalize.

Google managed packages should really be prioritized internally when major releases like 2.0.1 come out. Something to keep an eye on moving forward perhaps.

We would all greatly appreciate not having to use dependency-overrides. ❤️ Thanks for your time whomever comes to the rescue 🎉

@agilob
Copy link

agilob commented Mar 6, 2021

Google doesn't accept external contributions on any of their published flutter addons. Each and every readme contains:

This project is developed internally at Google and published for external consumption, external contributions unfortunately cannot be taken at this time.

@Simpler1
Copy link

Simpler1 commented Mar 6, 2021

With no updates in over a year, I think this package has been abandoned by Google. It may be time to start migrating to syncfusion_flutter_charts.

@agilob
Copy link

agilob commented Mar 6, 2021

@Simpler1 no.

Disclaimer: This is a commercial package. To use this package, you need to have either Syncfusion Commercial License or Free Syncfusion Community license. For more details, please check the LICENSE file.

@joleaf
Copy link

joleaf commented Mar 7, 2021

Google, please review :(

@cbbraun
Copy link
Contributor

cbbraun commented Mar 8, 2021

Sorry for the lack of response so far.

As you have picked up on, this specific project has been severely deprioritized and has only occasional volunteers trying to keep the lights on (and even there we haven't been able to keep up). While I am personally passionate about data visualizations on many platforms, the internal support we had evaporated. Flutter (and even Dart) isn't part of my normal development which makes it even harder to keep up on it.

In addition to the staffing/resource issue, the other inconvenient problem is that the "source" lives within google's repository and is pushed to github, which means it isn't a simple "approve pull request".

I'll see if I can get some of the smaller easy pull requests approved and pushed back out into github over the next week or so. And I hope to try to setup time to more regularly review pull requests.

I hope to get the project revitalized in the future, even hoping to find a team to take the torch, but that'll take some internal backing that I've yet to see so far.

Thanks for you patience and sorry for the many inconveniences.

Copy link

@hey24sheep hey24sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@netlob netlob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. please merge asap

Copy link

@Pwuts Pwuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! taking way too long

cbbraun pushed a commit that referenced this pull request Mar 8, 2021
intl: ">=0.15.2 < 0.18.0"

Closes #598

PiperOrigin-RevId: 361636495
cbbraun pushed a commit that referenced this pull request Mar 9, 2021
intl: ">=0.15.2 < 0.18.0"

Closes #598

PiperOrigin-RevId: 361636495
@cbbraun cbbraun closed this in 1a00e94 Mar 9, 2021
@kevlar700
Copy link

Thank You @cbbraun

@hey24sheep
Copy link

Thank you @cbbraun This fixes it but we still need version bump/update of charts

jananitakumitech pushed a commit to jananitakumitech/charts_flutter that referenced this pull request Aug 13, 2021
* Internal changes

PiperOrigin-RevId: 298455490

* Internal changes

PiperOrigin-RevId: 299212474

* Internal changes

PiperOrigin-RevId: 299384685

* Internal changes

PiperOrigin-RevId: 299911795

* Apply sort_child_properties_last lint so we can enable it in google3.

This enhances readability in *majority* of the cases by moving properties of a widget to the top. See: https://dart-lang.github.io/linter/lints/sort_child_properties_last.html

Tested:
    TAP --sample ran all affected tests and none failed
    http://test/OCL:300415528:BASE:300394685:1583970262840:214ae086
PiperOrigin-RevId: 300472053

* Internal changes

PiperOrigin-RevId: 300583916

* Internal changes

PiperOrigin-RevId: 301253904

* Internal changes

PiperOrigin-RevId: 301413179

* Correct the point location computation to be inside of scale's range if it is outside of scale range but only outside by less than epsilon in order to avoid potential mislocation caused by floating point computation.

PiperOrigin-RevId: 301644128

* Internal changes

PiperOrigin-RevId: 301919359

* Internal changes

PiperOrigin-RevId: 305070616

* Point renderer has now the option to select all points overlapping the interaction point

PiperOrigin-RevId: 306413187

* Internal Changes

PiperOrigin-RevId: 306960748

* Fix missing_return errors for anonymous closures.

These are mostly closures whose type dictates that a Future of something-or-other be returned. Fixes include:

* Make the closure async
* Add a return statement

Tested:
    TAP for global presubmit queue
    http://test/OCL:307493015:BASE:307542828:1587474095828:2c1a77e8
PiperOrigin-RevId: 308003343

* Internal change

PiperOrigin-RevId: 308058514

* Allow using up/down arrow keys to change the hovered bar in a chart. Also add preventDefault so the page doesn't scroll.

PiperOrigin-RevId: 308932972

* Internal change

PiperOrigin-RevId: 309073218

* Internal changes

PiperOrigin-RevId: 309494957

* Add TriangleSymbolRenderer

PiperOrigin-RevId: 310472091

* Expose additional classes

PiperOrigin-RevId: 310943783

* Change MaterialGray shade900 from blue to correct gray

PiperOrigin-RevId: 311587781

* Pass `DateTimeFactory` to `TimeSeriesChart`

PiperOrigin-RevId: 311764962

* Add setting to allow series to be always visible and unclickable in the chart legend.

PiperOrigin-RevId: 314159954

* Export additional classes

PiperOrigin-RevId: 314565994

* Add custom legend ordering by sorting the behaviors series list based on a list with ordered series IDs.

PiperOrigin-RevId: 315910283

* Add custom axis renderer for range ticks.

PiperOrigin-RevId: 315976899

* Internal changes.

PiperOrigin-RevId: 318221788

* Set datum index for legend entry

PiperOrigin-RevId: 319291348

* Internal changes

PiperOrigin-RevId: 322200941

* Internal changes

PiperOrigin-RevId: 322451897

* Internal changes.

PiperOrigin-RevId: 322661249

* Internal changes

PiperOrigin-RevId: 322671049

* Internal changes

PiperOrigin-RevId: 322827055

* Override setState fn with mounted check in baseChartState.

PiperOrigin-RevId: 325307554

* Internal changes

PiperOrigin-RevId: 326067746

* Internal changes

PiperOrigin-RevId: 328177790

* Internal changes

PiperOrigin-RevId: 331718263

* Internal changes

PiperOrigin-RevId: 331738992

* Internal changes

PiperOrigin-RevId: 331765706

* Automated g4 rollback of changelist 331765706.

*** Reason for rollback ***

Manually rolled back on behalf of: oreflow.
Reason Given: This CL auto rolled back a rollback. Rolling forward to a broken revision

*** Original change description ***

Automated g4 rollback of changelist 331738992.

*** Reason for rollback ***

TAP has detected 10 or more targets failed to build at cl/331738992.

TO ROLLFORWARD (without additional approval): Use go/undo-autorollback and consider filing a go/autorollback-bug.

To see all broken targets visit http://test/331738992 or go/newly-broken?p=cl:331738992 if the former is slow to load.
To prevent noise from flakes, TAP double-checked the following target fails to build:
https://sponge.corp.google.com/in...

***

PiperOrigin-RevId: 331767278

* Internal changes

PiperOrigin-RevId: 336974207

* Internal changes

PiperOrigin-RevId: 337212864

* Test-only change to prepare for new Flutter version

PiperOrigin-RevId: 339319134

* Internal changes

PiperOrigin-RevId: 340251505

* Internal changes

PiperOrigin-RevId: 340463455

* Internal changes

PiperOrigin-RevId: 340658840

* Internal changes

PiperOrigin-RevId: 342347503

* Internal changes

PiperOrigin-RevId: 345724352

* Internal changes

PiperOrigin-RevId: 347872889

* Internal changes

PiperOrigin-RevId: 350249482

* Clean up violations of Dart lint unnecessary_parenthesis

In preparation for null safety migration, I'm first fixing numerous
analysis complaints in the hope that it will make the migration go a
little bit more smoothly.

Remove unnecessary parentheses.

PiperOrigin-RevId: 360550907

* Clean up violations of Dart lint annotate_overrides

Add missing `@override` annotations.  This caught a bug where
`hashCode` was not overridden as intended because it was accidentally
mistyped as `hashcode`.

PiperOrigin-RevId: 360551084

* Clean up violations of Dart lint unnecessary_getters_setters

Replace trivial getters and setters with fields.

PiperOrigin-RevId: 360551490

* Clean up violations of Dart lint prefer_collection_literals

Use collection literals where possible.  Because a lot of this code
explicitly uses `LinkedHashMap` to indicate that order is important,
add appropriate `// ignore` comments until
https://github.com/dart-lang/linter/issues/1649 is addressed.

PiperOrigin-RevId: 360552809

* Clean up less trivial violations of miscellaneous Dart lints

* prefer_null_aware_operators
* hash_and_equals
* only_throw_errors
* avoid_bool_literals_in_conditional_expressions

Also replace usage of the deprecated zero-argument `List`
constructor.

PiperOrigin-RevId: 360552940

* Clean up trivial violations of miscellaneous Dart lints

* unnecessary_this
* prefer_final_fields
* avoid_single_cascade_in_expression_statements
* avoid_renaming_method_parameters

Also:
* Remove unused variables.
* Fix some cases where fields were implicitly `dynamic` because their
  type was omitted.
PiperOrigin-RevId: 360553040

* bump intl version to 0.18.0

intl: ">=0.15.2 < 0.18.0"

Closes google/charts#598

PiperOrigin-RevId: 361636495

* Internal changes

PiperOrigin-RevId: 361680107

Co-authored-by: nolankelly <[email protected]>
Co-authored-by: Googler <[email protected]>
Co-authored-by: mehmetf <[email protected]>
Co-authored-by: srawlins <[email protected]>
Co-authored-by: rearnshaw <[email protected]>
Co-authored-by: jiamingc <[email protected]>
Co-authored-by: jamesdlin <[email protected]>
Co-authored-by: Artyom Sasin <[email protected]>
Co-authored-by: lorrainekan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.