Skip to content

Commit

Permalink
Delete SHARE_BUILD_WITH_JOB_TYPE feature.
Browse files Browse the repository at this point in the history
It's a clever feature that needs bad complexity to support and doesn't appear to
be used.
Fixes: #4195
  • Loading branch information
jonathanmetzman committed Aug 21, 2024
1 parent 8374e0c commit 3c1b8ef
Showing 1 changed file with 1 addition and 15 deletions.
16 changes: 1 addition & 15 deletions src/clusterfuzz/_internal/build_management/build_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -1279,17 +1279,7 @@ def setup_symbolized_builds(revision):

def setup_custom_binary(target_weights=None):
"""Set up the custom binary for a particular job."""
# Check if this build is dependent on any other custom job. If yes,
# then fake out our job name for setting up the build.
old_job_name = ''
share_build_job_type = environment.get_value('SHARE_BUILD_WITH_JOB_TYPE')
if share_build_job_type:
job_name = share_build_job_type
old_job_name = environment.get_value('JOB_NAME', '')
environment.set_value('JOB_NAME', job_name)
else:
job_name = environment.get_value('JOB_NAME', '')

job_name = environment.get_value('JOB_NAME')
# Verify that this is really a custom binary job.
job = data_types.Job.query(data_types.Job.name == job_name).get()
if not job or not job.custom_binary_key or not job.custom_binary_filename:
Expand All @@ -1305,10 +1295,6 @@ def setup_custom_binary(target_weights=None):
job.custom_binary_revision,
target_weights=target_weights)

# Revert back the actual job name.
if share_build_job_type:
environment.set_value('JOB_NAME', old_job_name)

if build.setup():
return build

Expand Down

0 comments on commit 3c1b8ef

Please sign in to comment.