Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete SHARE_BUILD_WITH_JOB_TYPE feature. #4195

Closed
jonathanmetzman opened this issue Aug 21, 2024 · 0 comments · Fixed by #4197
Closed

Delete SHARE_BUILD_WITH_JOB_TYPE feature. #4195

jonathanmetzman opened this issue Aug 21, 2024 · 0 comments · Fixed by #4197

Comments

@jonathanmetzman
Copy link
Collaborator

It's unclear if we are using it at all and it's implementation requires this horrendous bit of code:

  # Check if this build is dependent on any other custom job. If yes,
  # then fake out our job name for setting up the build.
  old_job_name = ''
  share_build_job_type = environment.get_value('SHARE_BUILD_WITH_JOB_TYPE')
  if share_build_job_type:
    job_name = share_build_job_type
    old_job_name = environment.get_value('JOB_NAME', '')
    environment.set_value('JOB_NAME', job_name)
  else:
    job_name = environment.get_value('JOB_NAME', '')
jonathanmetzman added a commit that referenced this issue Aug 21, 2024
@jonathanmetzman
Delete SHARE_BUILD_WITH_JOB_TYPE feature.
3c1b8ef 
It's a clever feature that needs bad complexity to support and doesn't appear to
be used.
Fixes: #4195
@jonathanmetzman jonathanmetzman mentioned this issue Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete SHARE_BUILD_WITH_JOB_TYPE feature. google/clusterfuzz
1 participant
@jonathanmetzman