-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add asynchronous downloading to speed up signed URL downloading. #4266
Conversation
TODO: Do this for other http methods. |
Do we have any idea of how long the downloading step takes from past profiling data, on fuzz task? (back when those profiling images were around) |
], | ||
"index": "pypi", | ||
"markers": "python_version >= '3.8'", | ||
"version": "==3.10.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these dep bumps supported in our platforms?
There should be complaints from
clusterfuzz/src/local/butler/common.py
Line 295 in 044ec08
print(f'Did not find package for platform: {pip_platform}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might also need to rebuild docker, since httpaio is a new dep with C extensions to access async syscalls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure we're not using the C extensions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I'll know what to look out for if I see a problem.
We got rid of profiling before we switched to this new method of downloading, but seeing as the new method can take up to 15 minutes, I think the savings will be substantial. |
Please take a another look. |
The speed ups are up to 20x on my own machine.
It's even faster with one core than 16 parallel processes.