Enriching BOT_COUNT metric #4330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -786,6 +787,14 @@ def platform(): | |||
| raise ValueError('Unsupported platform "%s".' % sys.platform) | |||
|
|
|||
|
|
|||
| def platform_vesion(): | |||
There was a problem hiding this comment.
Is this needed? Also it's spelled wrong.
There was a problem hiding this comment.
Chrome folks asked for it, as per design doc. I think it is a good idea to have it, so we can, for instance, figure out what glibc to expect in every environment without having to ask around or read internal config/code
vitorguidi
force-pushed
the
feature/enrich-bot-count
branch
from
34023d6
to
cd9f0bc
Compare
|
Does this mean that the change wasn't merged? |
Yes, it is now being done in #4333 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As a request from the Chrome team, it would be nice to know what:
a bot corresponds to. This PR implements that.
Part of #4271