[Monitoring] Adding test case reproducibility metric #4358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverchang
reviewed
Oct 27, 2024
vitorguidi
commented
Oct 29, 2024
| @@ -2045,8 +2045,7 @@ def _to_engine_output(output: str, return_code: int, | |||
| def _upload_engine_output_log(engine_output): | |||
| timestamp = uworker_io.proto_timestamp_to_timestamp(engine_output.timestamp) | |||
| testcase_manager.upload_log(engine_output.output.decode(), | |||
| engine_output.return_code, | |||
| timestamp) | |||
| engine_output.return_code, timestamp) | |||
There was a problem hiding this comment.
This is a linter complaint
alhijazi
approved these changes
Nov 4, 2024
vitorguidi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Chrome team has no easy visibility into how many manually uploaded test cases flake or successfully reproduce. This PR implements a counter metric to track that.
There are three possible outcomes, each represented by a string label: 'reproduces', 'one_timer' and 'does_not_reproduce'
Part of #4271