forked from square/dagger
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KSP][Android] Delete a hilt view model breaks incremental compilation in ksp #4060
Comments
I saw this too when I deleted an |
This was referenced Sep 22, 2023
This looks like an issue in KSP. I've filed a bug here: google/ksp#1554. |
This was referenced Sep 26, 2023
copybara-service bot
pushed a commit
that referenced
this issue
Nov 29, 2023
…0-1.0.14`. This should bring in a number of fixes in KSP, especially related to incremental processing. Fixes #4060 RELNOTES=Upgrade Dagger's dependencies of kotlin to `1.9.20` and ksp to `1.9.20-1.0.14`. PiperOrigin-RevId: 586380958
copybara-service bot
pushed a commit
that referenced
this issue
Nov 29, 2023
…0-1.0.14`. This should bring in a number of fixes in KSP, especially related to incremental processing. Fixes #4060 RELNOTES=Upgrade Dagger's dependencies of kotlin to `1.9.20` and ksp to `1.9.20-1.0.14`. PiperOrigin-RevId: 586380958
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi team,
Congrats on the KSP release!
After migrating to KSP, I found that there is an issue related to
@HiltViewModel
in my Android project. If I delete the view model, the incremental compilation will break in KSP, with the following message:I also created a simple repository to demonstrate this issue: https://github.com/ZhaohuaZeng-at/dagger-demo-viewmodel-bug-ksp
Overview of the repo branches:
ProfileScreenViewModel
ProfileScreenViewModel
Here is the steps to reproduce:
git checkout remove_viewmodel
, build project incrementally via "run app"If I do a clean build in
remove_viewmodel
, build can succeed, but this is annoying.This error is not reproducible with the
kapt
andkapt-remove-viewmodel
branches.The text was updated successfully, but these errors were encountered: