Update Maven usage in README to suggest annotationProcessorPaths #293
Conversation
| <groupId>com.google.auto.value</groupId> | ||
| <artifactId>auto-value</artifactId> | ||
| <version>${auto.value.version}</version> | ||
| <scope>provided</scope> <!-- to leave out of the all-deps jar --> | ||
| <scope>provided</scope> <!-- only needed for the annotations --> |
There was a problem hiding this comment.
Hopefully this will motivate google/auto#268 😀
|
Hmm, maybe samples should not be updated to It's also worth waiting for version 3.6 of the maven-compiler-plugin that will fix the incremental build issue introduced in 3.2 (three years ago or so). Feel free to close this PR following those findings. |
tbroyer
force-pushed
the
m-compiler-p-3.5
branch
from
af64e78
to
24b6e03
Compare
|
Updated to only use Use of |
| @@ -69,10 +63,17 @@ limitations under the License. | |||
| <plugins> | |||
| <plugin> | |||
| <artifactId>maven-compiler-plugin</artifactId> | |||
| <version>3.1</version> | |||
| <version>3.5.1</version> | |||
There was a problem hiding this comment.
Can you define a variable for this in the root pom.xml?
There was a problem hiding this comment.
Or, is there a way to set the default and then have that be implicit?
|
I'm in the process of switching us to use |
|
Yay for bazel though I wonder how you'll deploy releases (and snapshots?) to Central. But yes, probably not worth it. Feel free to close. |
|
You can still use |
|
I rather meant the non/less-technical part: ensuring java_library↔pom parity, making sure things work for non-bazel users, etc. |
annotationProcessorPaths has some issues (no dependencyManagement, dependency:go-offline, or versions:display-dependency-updates), so don't replace the current documentation using optional dependency. Also update net.ltgt.apt plugin in Gradle usage to the latest version.
tbroyer
force-pushed
the
m-compiler-p-3.5
branch
from
24b6e03
to
976b10f
Compare
|
Now that the build has moved to Bazel, this PR only updates the README (and I'll send a PR for the users-guide if/when that one's accepted) |
tbroyer
changed the title
|
LGTM. Let's put both the README and users guide changes in the same PR and then I'll grab all the changes in? |
|
Btw don't worry about squashing since it effectively happens when we merge internally |
users guide is in a different branch ;-) BTW, there are Gradle instructions in the README, should those be added to the users guide too? (as we're at it) |
|
I've always found it a little weird that we have this duplicated. I think it's probably in the best interest of our users though to have it in both locations. SGTM. If you create both PRs, I'll take a look at both and submit. I forgot that they were different branches on github |
|
See #719 The users guide was already deferring to the README for Gradle, so I removed the Maven instructions. Let me know if you'd prefer to instead duplicate all instructions in the users guide. |
Also defer to the README instructions for all build tools (rather than just Gradle) Fixes #293 Fixes #719 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=154857182
Also defer to the README instructions for all build tools (rather than just Gradle) Fixes #293 Fixes #719 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=154857182
Also defer to the README instructions for all build tools (rather than just Gradle) Fixes #293 Fixes #719 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=154857182
Note that the online doc (
gh-pages) needs to be updated too; I'll do a followup pull request if this one's accepted.