Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hilt: skip view injection in edit mode #4305

Closed
wants to merge 1 commit into from
Closed

Hilt: skip view injection in edit mode #4305

wants to merge 1 commit into from

Conversation

3dm1
Copy link

@3dm1 3dm1 commented May 9, 2024

This code change includes a check to skip injecting views in case View#isInEditMode returns true, i.e. view is displayed in IDE's XML layout editor preview.

Main driver for this change is that I'm running a BUCK project and can only reliably get the version of view classes that extend from the generated Hilt_ classes. These cannot be instantiated in the preview since the view injector requires an application context, which is unavailable.

More importantly this is no-op in Gradle projects, since modified classes are never loaded by it, so there are no other side effects.

Copy link

google-cla bot commented May 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

copybara-service bot pushed a commit that referenced this pull request Jun 10, 2024
Closes #4305

RELNOTES=Skip view injection when in edit mode for previews.
PiperOrigin-RevId: 640680452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant