Moe sync 11/15/2016 #498
Merged
Moe sync 11/15/2016 #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=139125765
…ublicly accessible way to invoke package-private methods and constructors. Then, use those proxy methods directly to fulfill requests that don't require Providers. The interaction of this behavior + the existing behavior to invoke accessible elements directly yields 861 proxy accesses and 511 direct accesses in []' CommonDataReloadComponent for example. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=139167112
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=139355153
ronshapiro
force-pushed
the
moe_sync_11/15/2016
branch
from
ec68afd
to
5abbc82
Compare
|
Interesting stuff! On Wed, Nov 16, 2016 at 5:21 PM Ron Shapiro [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.