Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.toml: comment typo: s/lang/length #143

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Conversation

mhansen
Copy link
Contributor

@mhansen mhansen commented Oct 24, 2021

I don't think taxonomyCloud has a language, and I think they need to have the same length, so I think this is what was intended.

mhansen and others added 2 commits October 24, 2021 17:38
I don't think taxonomyCloud has a language, and I think they need to have the same length, so I think this is what was intended.
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the typo. Note that I unqualified the name in the comment (leaving it as it was before).

For the record, this propages the same fix as @deining did in google/docsy#922.

@chalin chalin merged commit 0b1a4d8 into google:master Mar 28, 2022
@chalin
Copy link
Collaborator

chalin commented Mar 28, 2022

PR build was failing. I rebased, and the build is passing now: https://app.netlify.com/sites/docsy-example/deploys/6241d5f6aee2b600087dac66

@mhansen mhansen deleted the patch-2 branch March 29, 2022 08:21
@mhansen
Copy link
Contributor Author

mhansen commented Mar 29, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants