Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.toml: change order of language settings and theme/module declaration #162

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

deining
Copy link
Collaborator

@deining deining commented Feb 2, 2022

When using docsy as hugo module, inside config.toml, the language settings must declared prior to the [module] section. If you do not obey this load order, you are running in trouble.
This PR moves the language settings inside config.toml up to the top of the file. By doing so, we are ensuring a smooth transition for users that want to pull the docsy theme into the example site as a hugo module.

…ration

(important when using docsy as hugo module)
@netlify
Copy link

netlify bot commented Feb 2, 2022

✔️ Deploy Preview for docsy-example ready!

🔨 Explore the source changes: f3cfd79

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsy-example/deploys/61faf42a4df1130008981304

😎 Browse the preview: https://deploy-preview-162--docsy-example.netlify.app

@chalin
Copy link
Collaborator

chalin commented Feb 14, 2022

When using docsy as hugo module, inside config.toml, the language settings must declared prior to the [module] section. If you do not obey this load order, you are running in trouble.

Just curious if this is documented or discussed anywhere?

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chalin chalin merged commit 6224cd2 into google:master Feb 14, 2022
@deining deining deleted the load-order branch February 22, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants