Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default baseURL as example.org #205

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Change the default baseURL as example.org #205

merged 1 commit into from
Mar 21, 2024

Conversation

razonyang
Copy link
Contributor

A minor change that allow clicking the URL from console.

hugo server
...
Web Server is available at //localhost:1313/ (bind address 127.0.0.1)

With this PR:

hugo server
...
Web Server is available at http://localhost:1313/ (bind address 127.0.0.1)

deining
deining approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

chalin
chalin requested changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The baseURL should match the currently hosted site path.

/cc @emckean @LisaFC @geriom

@deining
Copy link
Collaborator

deining commented Nov 17, 2023

Can you please rebase and resolve merge conflicts? Thanks.

@razonyang razonyang closed this Nov 17, 2023
@razonyang razonyang reopened this Nov 17, 2023
@razonyang
Copy link
Contributor Author

Done, seems there are a lot of changes, I re-fork and apply the changes on new configuration file.

chalin
chalin approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@deining deining merged commit 27caf88 into google:main Mar 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

@deining deining deining approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@razonyang @deining @chalin