fix tutorial for groundwater recharge calculation with EE #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
guiattard
commented
Jul 15, 2024
guiattard
commented
- fix the sign in the description of the equation of apwl (case 2.2),
- sort the meteo collection by date,
- fix confusion between stfc and prev_st
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
schwehr
reviewed
Jul 18, 2024
| @@ -1027,8 +1027,8 @@ | |||
| }, | |||
| "outputs": [], | |||
| "source": [ | |||
| "# Combine precipitation and evapotranspiration.\n", | |||
| "meteo = pr_m.combine(pet_m)\n", | |||
| "# Combine precipitation and evapotranspiration, and sort the collection.\n", | |||
There was a problem hiding this comment.
No need to mention the sort in the comment. That's redundant to what's in the code.
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
- codespell - Remove a comment that is redundant to the what is in the code. - Follow up to #838 PiperOrigin-RevId: 653782028
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
- codespell - Remove a comment that is redundant to the what is in the code. - Follow up to #838 PiperOrigin-RevId: 653782028
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
- codespell - Remove a comment that is redundant to the what is in the code. - Follow up to #838 PiperOrigin-RevId: 653791427
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.