-
Notifications
You must be signed in to change notification settings - Fork 889
Conversation
Let's link in the description the ticket this PR address if one does not exist. If it does not let' create it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we version the used jquery.min.js and jquery.js in their name, that way we know what version they are/were ? (e.g: add version to the name of the .js files)
Let's add verification steps for a reviewer/tester to follow. |
That might be out of scope for this PR. This was just to upgrade jquery. If we want to version it that's going to require more work to update all of the jquery references in the code base. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good.
Sorry found some more places in docs that used an old version of jquery. We also have several "versions" of the static fold for docs that seem to get moved depending on tag versions. I'm only updating the jquery file in the 5.3.8 geedocs folder. |
It's come to my understanding that docs are generated manually and pushed into the |
This reverts commit 0d339d7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the current set of changes; re-approving.
Upgrading jquery to 3.6.0 for STIG and CVE issues.
Verification Steps:
/opt/google/gehttpd/htdocs/js/jquery.js
is 3.6.0