Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Upgrade jquery #1966

Closed
wants to merge 6 commits into from
Closed

Conversation

iparanza
Copy link
Contributor

@iparanza iparanza commented May 24, 2021

Upgrading jquery to 3.6.0 for STIG and CVE issues.

Verification Steps:

  • Build gee and deploy server
  • Verify jquery version in /opt/google/gehttpd/htdocs/js/jquery.js is 3.6.0

@google-cla google-cla bot added the cla: yes Manual verification that all contributors have signed the CLA. label May 24, 2021
@tst-nfarah
Copy link
Collaborator

Let's link in the description the ticket this PR address if one does not exist. If it does not let' create it.

Copy link
Collaborator

@tst-nfarah tst-nfarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we version the used jquery.min.js and jquery.js in their name, that way we know what version they are/were ? (e.g: add version to the name of the .js files)

@tst-nfarah
Copy link
Collaborator

Let's add verification steps for a reviewer/tester to follow.

@iparanza
Copy link
Contributor Author

Should we version the used jquery.min.js and jquery.js in their name, that way we know what version they are/were ? (e.g: add version to the name of the .js files)

That might be out of scope for this PR. This was just to upgrade jquery. If we want to version it that's going to require more work to update all of the jquery references in the code base.

Copy link
Collaborator

@tst-mbiancalana tst-mbiancalana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good.

@iparanza
Copy link
Contributor Author

Sorry found some more places in docs that used an old version of jquery. We also have several "versions" of the static fold for docs that seem to get moved depending on tag versions. I'm only updating the jquery file in the 5.3.8 geedocs folder.

@iparanza
Copy link
Contributor Author

It's come to my understanding that docs are generated manually and pushed into the geedocs folder. The jquery version being packaged comes from using an old version of sphinx mentioned in the build docs readme. I'm going to back out the docs portion of this PR and submit another one to handle jquery in the docs.

Copy link
Collaborator

@tst-mbiancalana tst-mbiancalana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current set of changes; re-approving.

@tst-nfarah tst-nfarah closed this Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Manual verification that all contributors have signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants