Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require strict equality #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Require strict equality #67

wants to merge 1 commit into from

Conversation

mykhalov
Copy link

@mykhalov mykhalov commented Mar 3, 2021

The guide dictates that strict equality must be used with an exception for x == null, which matches ESLint's eqeqeq: 'smart' behaviour.

@google-cla
Copy link

google-cla bot commented Mar 3, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mykhalov
Copy link
Author

mykhalov commented Mar 3, 2021

@googlebot I signed it!

The guide dictates that [strict equality must be used](https://google.github.io/styleguide/jsguide.html#features-equality-checks) with an exception for `x == null`, which matches ESLint's `eqeqeq: 'smart'` behaviour.
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant