Addressed some comments in the PR

google · Aug 16, 2024 · 409943b · 409943b
1 parent ac6426c
commit 409943b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/filament/backend/src/vulkan/VulkanDriver.cpp b/filament/backend/src/vulkan/VulkanDriver.cpp
@@ -1298,9 +1298,9 @@ void VulkanDriver::beginRenderPass(Handle<HwRenderTarget> rth, const RenderPassP
             if (rpkey.samples > 1) {
                 const VulkanTexture* sidecar = info.texture->getSidecar();
                 assert_invariant(sidecar);
+				assert_invariant(sidecar->samples > 1);
                 if (sidecar && sidecar->isTransientAttachment()) {
                     rpkey.usesLazilyAllocatedMemory |= (1 << i);
-                    assert_invariant(sidecar->samples > 1);
                 }
                 if (info.texture->samples == 1) {
                     rpkey.needsResolveMask |= (1 << i);

diff --git a/filament/backend/src/vulkan/VulkanTexture.cpp b/filament/backend/src/vulkan/VulkanTexture.cpp
@@ -104,7 +104,7 @@ VulkanTexture::VulkanTexture(VkDevice device, VkPhysicalDevice physicalDevice,
         // Lazily allocated memory is available.
         context.isLazilyAllocatedMemorySupported() &&
         // Usage consists of attachment flags only.
-        !any(tusage & ~TextureUsage::ALL_ATTACHMENTS) &&
+        none(tusage & ~TextureUsage::ALL_ATTACHMENTS) &&
         // Usage contains at least one attachment flag.
         any(tusage & TextureUsage::ALL_ATTACHMENTS);
     mIsTransientAttachment = useTransientAttachment;