Skip to content

Commit

Permalink
vk: fix broken gltf renderings (#7680)
Browse files Browse the repository at this point in the history
This is due to color attachments being set to store=discard when
they are multi-sampled. It's unclear why that condition exists. For
now, removing it will fix the rendering issues with transparent
object + MSAA. We'll keep it as such until an issue surfaces.

Fixes #7674
  • Loading branch information
poweifeng authored Mar 19, 2024
1 parent 1ab223c commit dfa821d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion filament/backend/src/vulkan/VulkanFboCache.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ VkRenderPass VulkanFboCache::getRenderPass(RenderPassKey config) noexcept {
.format = config.colorFormat[i],
.samples = (VkSampleCountFlagBits) config.samples,
.loadOp = clear ? kClear : (discard ? kDontCare : kKeep),
.storeOp = config.samples == 1 ? kEnableStore : kDisableStore,
.storeOp = kEnableStore,
.stencilLoadOp = kDontCare,
.stencilStoreOp = kDisableStore,
.initialLayout = ((!discard && config.initialColorLayoutMask & (1 << i)) || clear)
Expand Down

0 comments on commit dfa821d

Please sign in to comment.