Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove textureUseAfterFreePoolSize and texture use-after-free #8163

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

bejado
Copy link
Member

@bejado bejado commented Sep 26, 2024

Remove textureUseAfterFreePoolSize, we'll switch to a more generic use-after-free detection for "heap" handles.

Copy link
Collaborator

@pixelflinger pixelflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of doing this -- it would be better to add generic use-after-free detection support for all "heap" handles.
this is also a rare case

@bejado bejado changed the title Add use after free checks for Metal textures Remove textureUseAfterFreePoolSize and texture use-after-free Oct 2, 2024
@bejado
Copy link
Member Author

bejado commented Oct 2, 2024

Switching this PR to just be the removal of the old check.

@bejado bejado force-pushed the bjd/descriptorsets-useafterfree branch from ec44b11 to fefccae Compare October 3, 2024 19:49
@bejado bejado changed the base branch from ma/descriptor-sets-1.54.5 to main October 3, 2024 19:50
Copy link

github-actions bot commented Oct 3, 2024

Please add a release note line to NEW_RELEASE_NOTES.md. If this PR does not warrant a release note, add the 'internal' label to this PR.

@bejado bejado merged commit 3b9fc8f into main Oct 4, 2024
10 of 12 checks passed
@bejado bejado deleted the bjd/descriptorsets-useafterfree branch October 4, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants