Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around client descriptor set issues #8171

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Work around client descriptor set issues #8171

merged 1 commit into from
Oct 2, 2024

Conversation

poweifeng
Copy link
Contributor

  • We change GLDescriptorSet::Buffer default constructor to workaround a client's compiler set up issue.
  • We removed the assert_invariant that checks that ubo/samplers are not changed after committed in DescriptorSet. This caused an existing client's build to crash.

@poweifeng
Work around client descriptor set issues
28f01f4 
- We change GLDescriptorSet::Buffer default constructor to
  workaround a client's compiler set up issue.
- We removed the assert_invariant that checks that ubo/samplers
  are not changed after committed in DescriptorSet. This caused
  an existing client's build to crash.
@poweifeng poweifeng added the internal Issue/PR does not affect clients label Oct 2, 2024
pixelflinger
pixelflinger approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@pixelflinger pixelflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but let's make sure to come back to this. in particular the extra bool in DescriptorSet will increase the size of descriptor sets by 8 bytes.

@poweifeng poweifeng merged commit e77ae6e into main Oct 2, 2024
13 checks passed
@poweifeng poweifeng deleted the pf/desc-set-workarounds branch October 2, 2024 13:24
poweifeng added a commit that referenced this pull request Oct 2, 2024
@poweifeng
Work around client descriptor set issues (#8171)
c6e2090 
- We change GLDescriptorSet::Buffer default constructor to
  workaround a client's compiler set up issue.
- We removed the assert_invariant that checks that ubo/samplers
  are not changed after committed in DescriptorSet. This caused
  an existing client's build to crash.
poweifeng added a commit that referenced this pull request Oct 2, 2024
@poweifeng
Work around client descriptor set issues (#8171)
0689e79 
- We change GLDescriptorSet::Buffer default constructor to
  workaround a client's compiler set up issue.
- We removed the assert_invariant that checks that ubo/samplers
  are not changed after committed in DescriptorSet. This caused
  an existing client's build to crash.
poweifeng added a commit that referenced this pull request Oct 2, 2024
@poweifeng
Work around client descriptor set issues (#8171)
b49ab5f 
- We change GLDescriptorSet::Buffer default constructor to
  workaround a client's compiler set up issue.
- We removed the assert_invariant that checks that ubo/samplers
  are not changed after committed in DescriptorSet. This caused
  an existing client's build to crash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelflinger pixelflinger pixelflinger approved these changes

Assignees
No one assigned
Labels
internal Issue/PR does not affect clients
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poweifeng @pixelflinger