Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dart] Failed to run in version 2.0.0-dev.69.2 #4836

Closed
6643 opened this issue Jul 24, 2018 · 4 comments
Closed

[dart] Failed to run in version 2.0.0-dev.69.2 #4836

6643 opened this issue Jul 24, 2018 · 4 comments

Comments

@6643
Copy link

6643 commented Jul 24, 2018

[error] Undefined name 'Endianness'. (package:flat_buffers/flat_buffers.dart, line 47, col 34)
[error] Undefined name 'Endianness'. (package:flat_buffers/flat_buffers.dart, line 50, col 34)
[error] Undefined name 'Endianness'. (package:flat_buffers/flat_buffers.dart, line 53, col 32)
[error] Undefined name 'Endianness'. (package:flat_buffers/flat_buffers.dart, line 56, col 32)
[error] Undefined name 'Endianness'. (package:flat_buffers/flat_buffers.dart, line 59, col 32)
[error] Undefined name 'Endianness'. (package:flat_buffers/flat_buffers.dart, line 64, col 33)
[error] Undefined name 'Endianness'. (package:flat_buffers/flat_buffers.dart, line 67, col 33)
[error] Undefined name 'Endianness'. (package:flat_buffers/flat_buffers.dart, line 70, col 33)
[error] Undefined name 'Endianness'. (package:flat_buffers/flat_buffers.dart, line 309, col 54)
[error] Undefined name 'UTF8'. (package:flat_buffers/flat_buffers.dart, line 663, col 23)
[error] Undefined name 'Endianness'. (package:flat_buffers/flat_buffers.dart, line 736, col 51)
[error] Undefined name 'Endianness'. (package:flat_buffers/flat_buffers.dart, line 740, col 51)
[error] Undefined name 'Endianness'. (package:flat_buffers/flat_buffers.dart, line 744, col 50)
[error] Undefined name 'Endianness'. (package:flat_buffers/flat_buffers.dart, line 748, col 49)
[error] Undefined name 'Endianness'. (package:flat_buffers/flat_buffers.dart, line 752, col 49)
[error] Undefined name 'Endianness'. (package:flat_buffers/flat_buffers.dart, line 756, col 50)
[error] Undefined name 'Endianness'. (package:flat_buffers/flat_buffers.dart, line 760, col 49)
[error] Undefined name 'Endianness'. (package:flat_buffers/flat_buffers.dart, line 764, col 50)
[error] Undefined name 'UTF8'. (package:flat_buffers/flat_buffers.dart, line 946, col 12)
[error] Undefined name 'Endianness'. (package:flat_buffers/flat_buffers.dart, line 1210, col 53)
[error] Undefined name 'Endianness'. (package:flat_buffers/flat_buffers.dart, line 1230, col 47)
[error] Undefined name 'Endianness'. (package:flat_buffers/flat_buffers.dart, line 1233, col 41)
[error] Undefined name 'Endianness'. (package:flat_buffers/flat_buffers.dart, line 1237, col 45)

change

Endianness.LITTLE_ENDIAN to Endian.little
UTF8 to utf8
@aardappel
Copy link
Collaborator

@dnfield

@dnfield
Copy link
Contributor

dnfield commented Jul 26, 2018

Looks like some of those deprecated names have finally been removed/renamed.

It's not hard to fix, but unfortunately would mean removing support for Dart 1 - which is probably ok - or creating two packages (one for Dart 1, one for Dart 2), which is annoying.

@dnfield
Copy link
Contributor

dnfield commented Jul 26, 2018

Yes, they were removed 8 days ago now - dart-lang/sdk@f2402b3

My preference would be to add an environment constraint (say, sdk: '>=2.0.0-dev.28.0 <3.0.0', which follows what a lot of the official Flutter plugins currently have), and update the constants. I can create a PR for that and maybe collect feedback there.

@aardappel this will require publishing a new Dart package to dart pub, but users could in theory refer directly to the git repository for now.

@dnfield
Copy link
Contributor

dnfield commented Jul 26, 2018

Also, this would be a great candidate for dart-lang/sdk#33249 - could conditionally wrap code with these references rather than needing to worry about how to support users who might still want to use Dart 1.x

That said, there is a working version of this lib that would still support Dart 1.x...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants