Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Dart 2.x constants #4842

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Update for Dart 2.x constants #4842

merged 1 commit into from
Jul 26, 2018

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Jul 26, 2018

Dart 2.x has removed support for some deprecated constants (Endianness and UTF8 in particular) that are used by this package.

This change will allow people to use latest/cutting edge releases of Dart, but removes support for 1.x

Users of Dart 1.x would have to use the previous version of this patch, and will not benefit from continued updates.

Fixes #4836 (more discussion there as well)

@aardappel
Copy link
Collaborator

Thanks!

@aardappel aardappel merged commit 2361dfb into google:master Jul 26, 2018
@6643
Copy link

6643 commented Jul 27, 2018

[1.9.1] Import failed

$ cat pubspec.yaml 
name: zhubao.bin

dependencies:
  flat_buffers: ^1.9.1


$ pub upgrade
Resolving dependencies... (3.3s)
Because zhubao.bin depends on flat_buffers ^1.9.1 which doesn't match any versions, version solving failed.

@dnfield
Copy link
Contributor Author

dnfield commented Jul 27, 2018

@aardappel it still needs to be published on pub - there's a script in the package to assist with that https://github.com/google/flatbuffers/blob/master/dart/publish.sh

@6643 in the meantime you can add a reference directly to Git, with something like this:

dependencies:
  flat_buffers:
    git:
      url: git://github.com/google/flatbuffers.git
      path: dart

@dnfield
Copy link
Contributor Author

dnfield commented Jul 27, 2018

@6643 I should add I haven't tested that but the documentation says it should work... If it doesn't, you can just pull it down locally somewhere and set it up as a local package.

@aardappel
Copy link
Collaborator

published: https://pub.dartlang.org/packages/flat_buffers

@6643
Copy link

6643 commented Jul 27, 2018

@dnfield @aardappel thanks

zchee pushed a commit to zchee/flatbuffers that referenced this pull request Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants