-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Public Sans #1923
Comments
Both Roman and Italic build with fontmake, I might start a draft PR just to get things moving. |
Thanks for getting this started. Let me know what you might need from our side. I'm unfamiliar with this process — can you point me to any relevant documentation? |
Extremely relevant, I'd like to use this font in my AMP-based website. (And it will be cool to use on Google Drive apps.) |
The fonts need to build with fontmake (not exported from Glyphs) and then they need to pass the quality assurance tests suite known as Font Bakery. After that, there is a walkthrough for making a Pull Request to Google Fonts here: https://github.com/googlefonts/gf-docs/tree/master/MakingPullRequestsToGF Font bakery produces a markdown report that can be submitted with the pull request. Since it seems like this is an active project, let's start making PRs to https://github.com/uswds/public-sans to fix whatever Font Bakery issues come up. Thanks! |
@thisisdano Here is the Font Bakery report for the Roman variable font; most issues here seem easy to fix: Fontbakery reportFontbakery version: 0.7.2 [3] Family checks🔥 FAIL: Check font has a license.
🔥 FAIL: Check that METADATA.pb family values are all the same.
⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?
[18] PublicSans.wght.ttf🔥 FAIL: Checking file is named canonically.
🔥 FAIL: Is 'gasp' table set to optimize rendering?
🔥 FAIL: Checks METADATA.pb font.post_script_name matches postscript name declared on the name table.
🔥 FAIL: METADATA.pb font.full_name value matches fullname declared on the name table?
🔥 FAIL: METADATA.pb font.post_script_name field contains font name in right format?
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb
🔥 FAIL: METADATA.pb: Filename is set canonically?
🔥 FAIL: METADATA.pb font.name and font.full_name fields match the values declared on the name table?
🔥 FAIL: Font enables smart dropout control in "prep" table instructions?
🔥 FAIL: Checking OS/2 usWinAscent & usWinDescent.
🔥 FAIL: Checking OS/2 Metrics match hhea Metrics.
🔥 FAIL: Does the font have a DSIG table?
🔥 FAIL: Whitespace and non-breaking space have the same width?
⚠ WARN: Checking OS/2 achVendID.
⚠ WARN: Stricter unitsPerEm criteria for Google Fonts.
⚠ WARN: Are there caret positions declared for every ligature?
⚠ WARN: Is there kerning info for non-ligated sequences?
⚠ WARN: Check for points out of bounds.
Summary
|
I predict this typeface is going to see fairly widespread adoption as it fails nicely to system fonts (Roboto, San Francisco, Source) I'd dearly love for it to be available in Google apps. |
🦗🦗🦗 |
Is there any update? Can I help with anything? |
What's the status on this? Can't wait to start using this in my projects! |
Family is now in production https://fonts.google.com/specimen/Public+Sans. Enjoy. |
Woot! |
Hi! Is there any estimation of when this will appear in Google Apps? |
I'll see if we can get this into Sheets and Docs. |
Any update on adding it into Docs? |
@m4rc1e any update on getting it into Sheets and Docs? |
Hopefully next week. |
@m4rc1e noticed it wasn't added last week. Do you have an updated timeframe? |
@m4rc1e yes, am aware it's published to fonts.google.com (looks great!), though you previously mentioned planning to add it into Google Sheets and Google Docs apps and that's what my question was referring to. Can you clarify? |
I'll ask for the family to be pushed to docs today. Apologies for the delay. Our production push has been broken for the past fortnight. It should be fixed now. |
Ok Public Sans should be available in Google Docs. |
https://github.com/uswds/public-sans
The text was updated successfully, but these errors were encountered: