Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lifesavers: v3.001 added. #1473

Merged
merged 1 commit into from
Jun 12, 2019
Merged

lifesavers: v3.001 added. #1473

merged 1 commit into from
Jun 12, 2019

Conversation

m4rc1e
Copy link
Collaborator

@m4rc1e m4rc1e commented Mar 7, 2018 •
edited
Loading

Hotfixed from the google/fonts/ofl/lifesavers dir.

Fixes #1413.

FB Report

>> com.google.fonts/check/011
   Fonts have equal numbers of glyphs?
 * FAIL: ExtraBold has 436 glyphs while Bold has 437 glyphs.

   Result: FAIL

>> com.google.fonts/check/012
   Fonts have equal glyph names?
 * FAIL: Glyphname '.ttfautohint' is defined on ExtraBold but is missing on Bold, Regular.

   Result: FAIL

>> com.google.fonts/check/088
   Copyright notice is the same in all fonts?
 * FAIL: METADATA.pb: Copyright field value is inconsistent across family

   Result: FAIL

>> com.google.fonts/check/034 with ((u'font[0]', '/Users/marc/Documents/googlefonts/fonts/ofl/lifesavers/LifeSavers-Bold.ttf'),)
   Check if OS/2 xAvgCharWidth is correct.
 * FAIL: OS/2 xAvgCharWidth is 435 but should be 539 which corresponds to the average of all glyph widths in the font

   Result: FAIL

>> com.google.fonts/check/037 with ((u'font[0]', '/Users/marc/Documents/googlefonts/fonts/ofl/lifesavers/LifeSavers-Bold.ttf'),)
   Checking with Microsoft Font Validator.
 * FAIL: MS-FonVal: The xAvgCharWidth field does not equal the calculated value DETAILS: actual = 435, calc = 538
 * FAIL: MS-FonVal: Intersecting contours DETAILS: Glyph index 24
 * FAIL: MS-FonVal: Intersecting contours DETAILS: Glyph index 36
 * FAIL: MS-FonVal: Intersecting contours DETAILS: Glyph index 46
 * FAIL: MS-FonVal: Intersecting contours DETAILS: Glyph index 69
 * FAIL: MS-FonVal: Intersecting contours DETAILS: Glyph index 89
 * FAIL: MS-FonVal: Intersecting contours DETAILS: Glyph index 104
 * FAIL: MS-FonVal: Intersecting contours DETAILS: Glyph index 189
 * FAIL: MS-FonVal: Intersecting contours DETAILS: Glyph index 221
 * FAIL: MS-FonVal: Intersecting contours DETAILS: Glyph index 225
 * FAIL: MS-FonVal: Intersecting contours DETAILS: Glyph index 226
 * FAIL: MS-FonVal: Intersecting contours DETAILS: Glyph index 227
 * FAIL: MS-FonVal: Intersecting contours DETAILS: Glyph index 228
 * FAIL: MS-FonVal: Intersecting contours DETAILS: Glyph index 258
 * FAIL: MS-FonVal: Intersecting contours DETAILS: Glyph index 270
 * FAIL: MS-FonVal: Intersecting contours DETAILS: Glyph index 286
 * FAIL: MS-FonVal: Intersecting contours DETAILS: Glyph index 323
 * FAIL: MS-FonVal: Intersecting contours DETAILS: Glyph index 324
 * FAIL: MS-FonVal: Intersecting contours DETAILS: Glyph index 344
 * FAIL: MS-FonVal: Intersecting contours DETAILS: Glyph index 364
 * FAIL: MS-FonVal: Intersecting contours DETAILS: Glyph index 376
 * FAIL: MS-FonVal: Intersecting contours DETAILS: Glyph index 426

   Result: FAIL

>> com.google.fonts/check/058 with ((u'font[0]', '/Users/marc/Documents/googlefonts/fonts/ofl/lifesavers/LifeSavers-Bold.ttf'),)
   Glyph names are all valid?
 * FAIL: The following glyph names do not comply with naming conventions: ['.ttfautohint'] A glyph name may be up to 31 characters in length, must be entirely comprised of characters from the following set: A-Z a-z 0-9 .(period) _(underscore). and must not start with a digit or period. There are a few exceptions such as the special character ".notdef". The glyph names "twocents", "a1", and "_" are all valid, while "2cents" and ".twocents" are not.

   Result: FAIL

>> com.google.fonts/check/102 with ((u'font[0]', '/Users/marc/Documents/googlefonts/fonts/ofl/lifesavers/LifeSavers-Bold.ttf'),)
   Copyright notice on METADATA.pb matches canonical pattern?
 * FAIL: METADATA.pb: Copyright notices should match a pattern similar to: 'Copyright 2017 The Familyname Project Authors (git url)'
But instead we have got: 'Copyright (c) 2012, Pablo Impallari (www.impallari.comCopyright (c) 2012, Rodrigo Fuenzalida (www.rfuenzalida.com|[email protected] Reserved Font Name Life Savers.'w.ikern.com|[email protected]),

   Result: FAIL

>> com.google.fonts/check/034 with ((u'font[1]', '/Users/marc/Documents/googlefonts/fonts/ofl/lifesavers/LifeSavers-ExtraBold.ttf'),)
   Check if OS/2 xAvgCharWidth is correct.
 * FAIL: OS/2 xAvgCharWidth is 446 but should be 553 which corresponds to the average of all glyph widths in the font

   Result: FAIL

>> com.google.fonts/check/037 with ((u'font[1]', '/Users/marc/Documents/googlefonts/fonts/ofl/lifesavers/LifeSavers-ExtraBold.ttf'),)
   Checking with Microsoft Font Validator.
 * FAIL: MS-FonVal: The xAvgCharWidth field does not equal the calculated value DETAILS: actual = 446, calc = 552

   Result: FAIL

>> com.google.fonts/check/057 with ((u'font[1]', '/Users/marc/Documents/googlefonts/fonts/ofl/lifesavers/LifeSavers-ExtraBold.ttf'),)
   Name table entries should not contain line-breaks.
 * FAIL: Name entry COPYRIGHT_NOTICE on platform MACINTOSH contains a line-break.
 * FAIL: Name entry COPYRIGHT_NOTICE on platform WINDOWS contains a line-break.

   Result: FAIL

>> com.google.fonts/check/102 with ((u'font[1]', '/Users/marc/Documents/googlefonts/fonts/ofl/lifesavers/LifeSavers-ExtraBold.ttf'),)
   Copyright notice on METADATA.pb matches canonical pattern?
 * FAIL: METADATA.pb: Copyright notices should match a pattern similar to: 'Copyright 2017 The Familyname Project Authors (git url)'
But instead we have got: 'Copyright (c) 2012, Pablo Impallari (www.impallari.com|[email protected]),
Copyright (c) 2012, Rodrigo Fuenzalida (www.rfuenzalida.com|[email protected]),
Copyright (c) 2012, Igino Marini. (www.ikern.com|[email protected]),
with Reserved Font Name Life Savers.'

   Result: FAIL

>> com.google.fonts/check/034 with ((u'font[2]', '/Users/marc/Documents/googlefonts/fonts/ofl/lifesavers/LifeSavers-Regular.ttf'),)
   Check if OS/2 xAvgCharWidth is correct.
 * FAIL: OS/2 xAvgCharWidth is 419 but should be 520 which corresponds to the average of all glyph widths in the font

   Result: FAIL

>> com.google.fonts/check/037 with ((u'font[2]', '/Users/marc/Documents/googlefonts/fonts/ofl/lifesavers/LifeSavers-Regular.ttf'),)
   Checking with Microsoft Font Validator.
 * FAIL: MS-FonVal: The xAvgCharWidth field does not equal the calculated value DETAILS: actual = 419, calc = 519

   Result: FAIL

>> com.google.fonts/check/058 with ((u'font[2]', '/Users/marc/Documents/googlefonts/fonts/ofl/lifesavers/LifeSavers-Regular.ttf'),)
   Glyph names are all valid?
 * FAIL: The following glyph names do not comply with naming conventions: ['.ttfautohint'] A glyph name may be up to 31 characters in length, must be entirely comprised of characters from the following set: A-Z a-z 0-9 .(period) _(underscore). and must not start with a digit or period. There are a few exceptions such as the special character ".notdef". The glyph names "twocents", "a1", and "_" are all valid, while "2cents" and ".twocents" are not.

   Result: FAIL

>> com.google.fonts/check/102 with ((u'font[2]', '/Users/marc/Documents/googlefonts/fonts/ofl/lifesavers/LifeSavers-Regular.ttf'),)
   Copyright notice on METADATA.pb matches canonical pattern?
 * FAIL: METADATA.pb: Copyright notices should match a pattern similar to: 'Copyright 2017 The Familyname Project Authors (git url)'
But instead we have got: 'Copyright (c) 2012, Pablo Impallari (www.impallari.comCopyright (c) 2012, Rodrigo Fuenzalida (www.rfuenzalida.com|[email protected] Reserved Font Name Life Savers.'w.ikern.com|[email protected]),

   Result: FAIL

======== <Section: Default> ========
347 checks in section


Section results:

    ERROR: 0
    FAIL: 15
    WARN: 30
    SKIP: 33
    INFO: 12
    PASS: 257

======== END <Section: Default> ========

Total:

    ERROR: 0
    FAIL: 15
    WARN: 30
    SKIP: 33
    INFO: 12
    PASS: 257

[PPPPPPPPPFFPPPPPWPPPPPFPPPPPPWPPPPPPPFPPFSSPPPPPPWPPPPIPIPWPFPPIPPWWPPPPPPPPPWPPPSPPPPPPPPPPFWPPSPPPPPPPPPPWPPPWWPPPPPPPPPPPPISSSSSSPPPPWPPPPPPPFPPFSSPPPPPPWPPPPIPIPWFPPPIPPWWPPPPPPPPPPPPPSPPPPPPPPPPFWPPSPPPPPPPPPSSPPPWWSPPPPPPPPWPPISSSSSSPPPPWPPPPPPPFPPFSSPPPPPPWPPPPIPIPWPFPPIPPWWPPPPPPPPPWPPPSPPPPPPPPPPFWPPSPPPPPPPPPPWPPPWWPPPPPPPPPPPPISSSSSSP] 100%

DONE!

Diffbrowsers Reports

Regression Report:

Fonts: ["LifeSavers-Bold.ttf", "LifeSavers-ExtraBold.ttf", "LifeSavers-Regular.ttf"]

View: waterfall
WARNING: Desktop_Windows_7_ie_9.0_.jpg is different by 11 pixels

View: glyphs-all_26pt
PASSED: Desktop_Windows_7_chrome_50.0_.jpg is the same
PASSED: Desktop_Windows_7_ie_9.0_.jpg is the same
PASSED: Desktop_Windows_7_firefox_45.0_.jpg is the same
PASSED: Desktop_Windows_10_edge_15.0_.jpg is the same
PASSED: Google_Nexus_5_android_5.0_Android_Browser_.jpg is the same

IMG
desktop_windows_7_ie_9 0_

desktop_windows_7_firefox_45 0_

@m4rc1e
lifesavers: v3.001 added.
8840b90 
Hotfixed from the google/fonts/ofl/lifesavers dir.

Fixes google#1413
@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Mar 7, 2018

Simply updated name records, fsSelection, usWeightClass and fsType bits. I also gave the fonts Dsigs.

@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Jun 11, 2019

Fontbakery report

Fontbakery version: 0.7.5

[4] Family checks
🔥 FAIL: Fonts have equal numbers of glyphs?
🔥 FAIL: Fonts have equal glyph names?
🔥 FAIL: METADATA.pb: Copyright notice is the same in all fonts?
🔥 FAIL: Check that OS/2.fsSelection bold & italic settings are unique for each NameID1

[14] LifeSavers-Bold.ttf
🔥 FAIL: Check glyph coverage.
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb
🔥 FAIL: Copyright notices match canonical pattern in fonts
🔥 FAIL: Copyright field for this font on METADATA.pb matches all copyright notice entries on the name table ?
⚠ WARN: Font has old ttfautohint applied?
⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?
⚠ WARN: Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
⚠ WARN: Stricter unitsPerEm criteria for Google Fonts.
  • com.google.fonts/check/unitsperem_strict
  • ⚠ WARN Even though unitsPerEm (1000) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will likely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations.
⚠ WARN: Check if each glyph has the recommended amount of contours.
  • com.google.fonts/check/contour_count
  • ⚠ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

Glyph name: quoteleft Contours detected: 2 Expected: 1
Glyph name: quoteright Contours detected: 2 Expected: 1
Glyph name: quotesinglbase Contours detected: 2 Expected: 1
Glyph name: quotedblleft Contours detected: 4 Expected: 2
Glyph name: quotedblright Contours detected: 4 Expected: 2
Glyph name: quotedblbase Contours detected: 4 Expected: 2
Glyph name: percent Contours detected: 4 Expected: 5
Glyph name: yen Contours detected: 4 Expected: 1 or 2
Glyph name: Eth Contours detected: 3 Expected: 2
Glyph name: aogonek Contours detected: 3 Expected: 2
Glyph name: Dcroat Contours detected: 3 Expected: 2
Glyph name: dcroat Contours detected: 3 Expected: 2
Glyph name: eogonek Contours detected: 3 Expected: 2
Glyph name: hbar Contours detected: 2 Expected: 1
Glyph name: Lslash Contours detected: 2 Expected: 1
Glyph name: lslash Contours detected: 2 Expected: 1
Glyph name: seveneighths Contours detected: 6 Expected: 5
Glyph name: Tbar Contours detected: 2 Expected: 1
Glyph name: tbar Contours detected: 2 Expected: 1
Glyph name: Uogonek Contours detected: 2 Expected: 1
Glyph name: uogonek Contours detected: 2 Expected: 1
Glyph name: Oogonek Contours detected: 3 Expected: 2
Glyph name: oogonek Contours detected: 3 Expected: 2

⚠ WARN: Are there caret positions declared for every ligature?
  • com.google.fonts/check/ligature_carets
  • ⚠ WARN GDEF table is missing, but it is mandatory to declare it on fonts that provide ligature glyphs because the caret (text cursor) positioning for each ligature must be provided in this table. [code: GDEF-missing]
⚠ WARN: Is there kerning info for non-ligated sequences?

  • com.google.fonts/check/kerning_for_non_ligated_sequences

  • ⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f
    • f + b
    • b + f
    • f + h
    • h + f
    • f + i
    • i + f
    • f + j
    • j + f
    • f + k
    • k + f
    • f + l
    • l + b
    • h + i
    • i + j
    • j + k
    • k + l
    • l + t
    • l + l
    • t + t
    • t + z

    [code: lacks-kern-info]

⚠ WARN: Check if OS/2 xAvgCharWidth is correct.
⚠ WARN: Name table strings must not contain the string 'Reserved Font Name'.
⚠ WARN: Check for points out of bounds.
  • com.google.fonts/check/points_out_of_bounds
  • ⚠ WARN The following glyphs have coordinates which are out of bounds:
    [('backslash', 509.00126, -2.0), ('backslash', 509.00126, 9.0), ('backslash', 509.00126, 15.0), ('braceright', 89.01469999999998, 837.99652), ('braceright', 97.01422, 837.99652), ('braceright', 143.01146, 837.99652), ('braceright', 159.01049999999998, 837.99652), ('braceright', 335.99988, 432.02088), ('braceright', 335.99988, 406.02243999999996), ('braceright', 335.99988, 392.02328), ('caron', 277.0, 640.0306), ('caron', 272.0, 640.0306), ('caron', 43.0, 640.0306), ('caron', 38.0, 640.0306), ('caron', 27.0, 640.0306), ('caron', 283.0, 640.0306), ('ccaron', 393.0, 640.0306), ('ccaron', 388.0, 640.0306), ('ccaron', 159.0, 640.0306), ('ccaron', 154.0, 640.0306), ('ccaron', 143.0, 640.0306), ('ccaron', 399.0, 640.0306), ('ecaron', 370.0, 640.0306), ('ecaron', 365.0, 640.0306), ('ecaron', 136.0, 640.0306), ('ecaron', 131.0, 640.0306), ('ecaron', 120.0, 640.0306), ('ecaron', 376.0, 640.0306), ('guilsinglright', 222.00245999999999, 368.0), ('guilsinglright', 222.00245999999999, 378.0), ('guilsinglright', 222.00245999999999, 389.0), ('ncaron', 475.0, 640.0306), ('ncaron', 470.0, 640.0306), ('ncaron', 241.0, 640.0306), ('ncaron', 236.0, 640.0306), ('ncaron', 225.0, 640.0306), ('ncaron', 481.0, 640.0306), ('parenright', 225.00252, 492.01962), ('parenright', 225.00252, 410.02454), ('parenright', 225.00252, 328.02946), ('parenright', 60.01241999999999, 847.99826), ('parenright', 76.01146, 847.99826), ('parenright', 93.01043999999999, 847.99826), ('quotedblleft', 71.00533999999999, 918.03882), ('quotedblleft', 83.00462, 918.03882), ('quotedblleft', 96.00384, 918.03882), ('quotedblleft', 197.00534, 918.03882), ('quotedblleft', 209.00462, 918.03882), ('quotedblleft', 222.00384, 918.03882), ('quotedblleft', 247.00234, 789.04656), ('quotedblleft', 247.00234, 782.04698), ('quotedblleft', 247.00234, 777.04728), ('quoteleft', 71.00533999999999, 918.03882), ('quoteleft', 83.00462, 918.03882), ('quoteleft', 96.00384, 918.03882), ('quoteleft', 121.00234, 789.04656), ('quoteleft', 121.00234, 782.04698), ('quoteleft', 121.00234, 777.04728), ('rcaron', 313.0, 640.0306), ('rcaron', 308.0, 640.0306), ('rcaron', 79.0, 640.0306), ('rcaron', 74.0, 640.0306), ('rcaron', 63.0, 640.0306), ('rcaron', 319.0, 640.0306), ('scaron', 323.0, 640.0306), ('scaron', 318.0, 640.0306), ('scaron', 89.0, 640.0306), ('scaron', 84.0, 640.0306), ('scaron', 73.0, 640.0306), ('scaron', 329.0, 640.0306), ('zcaron', 360.0, 640.0306), ('zcaron', 355.0, 640.0306), ('zcaron', 126.0, 640.0306), ('zcaron', 121.0, 640.0306), ('zcaron', 110.0, 640.0306), ('zcaron', 366.0, 640.0306)]
    This happens a lot when points are not extremes, which is usually bad. However, fixing this alert by adding points on extremes may do more harm than good, especially with italics, calligraphic-script, handwriting, rounded and other fonts. So it is common to ignore this message

[14] LifeSavers-ExtraBold.ttf
🔥 FAIL: Check glyph coverage.
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb
🔥 FAIL: Copyright notices match canonical pattern in fonts
🔥 FAIL: Name table entries should not contain line-breaks.
  • com.google.fonts/check/name/line_breaks
  • 🔥 FAIL Name entry COPYRIGHT_NOTICE on platform MACINTOSH contains a line-break.
  • 🔥 FAIL Name entry COPYRIGHT_NOTICE on platform WINDOWS contains a line-break.
⚠ WARN: Font has old ttfautohint applied?
⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?
⚠ WARN: Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
⚠ WARN: Stricter unitsPerEm criteria for Google Fonts.
  • com.google.fonts/check/unitsperem_strict
  • ⚠ WARN Even though unitsPerEm (1000) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will likely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations.
⚠ WARN: Check if each glyph has the recommended amount of contours.
  • com.google.fonts/check/contour_count
  • ⚠ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

Glyph name: percent Contours detected: 4 Expected: 5
Glyph name: Ccaron Contours detected: 1 Expected: 2
Glyph name: Scaron Contours detected: 1 Expected: 2

⚠ WARN: Are there caret positions declared for every ligature?
  • com.google.fonts/check/ligature_carets
  • ⚠ WARN GDEF table is missing, but it is mandatory to declare it on fonts that provide ligature glyphs because the caret (text cursor) positioning for each ligature must be provided in this table. [code: GDEF-missing]
⚠ WARN: Is there kerning info for non-ligated sequences?

  • com.google.fonts/check/kerning_for_non_ligated_sequences

  • ⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f
    • f + b
    • b + f
    • f + h
    • h + f
    • f + i
    • i + f
    • f + j
    • j + f
    • f + k
    • k + f
    • f + l
    • l + b
    • h + i
    • i + j
    • j + k
    • k + l
    • l + t
    • l + l
    • t + t
    • t + z

    [code: lacks-kern-info]

⚠ WARN: Combined length of family and style must not exceed 27 characters.
⚠ WARN: Check if OS/2 xAvgCharWidth is correct.
⚠ WARN: Name table strings must not contain the string 'Reserved Font Name'.

[15] LifeSavers-Regular.ttf
🔥 FAIL: Check glyph coverage.
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb
🔥 FAIL: Copyright notices match canonical pattern in fonts
🔥 FAIL: Copyright field for this font on METADATA.pb matches all copyright notice entries on the name table ?
⚠ WARN: Checking OS/2 achVendID.
⚠ WARN: Font has old ttfautohint applied?
⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?
⚠ WARN: Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
⚠ WARN: Stricter unitsPerEm criteria for Google Fonts.
  • com.google.fonts/check/unitsperem_strict
  • ⚠ WARN Even though unitsPerEm (1000) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will likely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations.
⚠ WARN: Check if each glyph has the recommended amount of contours.
  • com.google.fonts/check/contour_count
  • ⚠ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

Glyph name: percent Contours detected: 4 Expected: 5
Glyph name: iogonek Contours detected: 1 Expected: 2 or 3

⚠ WARN: Are there caret positions declared for every ligature?
  • com.google.fonts/check/ligature_carets
  • ⚠ WARN GDEF table is missing, but it is mandatory to declare it on fonts that provide ligature glyphs because the caret (text cursor) positioning for each ligature must be provided in this table. [code: GDEF-missing]
⚠ WARN: Is there kerning info for non-ligated sequences?

  • com.google.fonts/check/kerning_for_non_ligated_sequences

  • ⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f
    • f + b
    • b + f
    • f + h
    • h + f
    • f + i
    • i + f
    • f + j
    • j + f
    • f + k
    • k + f
    • f + l
    • l + b
    • h + i
    • i + j
    • j + k
    • k + l
    • l + t
    • l + l
    • t + t
    • t + z

    [code: lacks-kern-info]

⚠ WARN: Check if OS/2 xAvgCharWidth is correct.
⚠ WARN: Name table strings must not contain the string 'Reserved Font Name'.
⚠ WARN: Check for points out of bounds.
  • com.google.fonts/check/points_out_of_bounds
  • ⚠ WARN The following glyphs have coordinates which are out of bounds:
    [('backslash', 483.00132, -19.0), ('backslash', 483.00132, -7.0), ('backslash', 483.00132, -1.0), ('braceright', 79.01404, 837.99652), ('braceright', 87.01355999999998, 837.99652), ('braceright', 118.01169999999999, 837.99652), ('braceright', 134.01074, 837.99652), ('braceright', 311.00012, 432.02088), ('braceright', 311.00012, 406.02243999999996), ('braceright', 311.00012, 392.02328), ('caron', 277.0, 640.0306), ('caron', 272.0, 640.0306), ('caron', 43.0, 640.0306), ('caron', 38.0, 640.0306), ('caron', 30.0, 640.0306), ('caron', 285.0, 640.0306), ('guilsinglright', 181.0027, 368.0), ('guilsinglright', 181.0027, 378.0), ('guilsinglright', 181.0027, 385.0), ('parenright', 196.00281999999999, 492.01962), ('parenright', 196.00281999999999, 410.02454), ('parenright', 196.00281999999999, 328.02946), ('parenright', 57.01115999999999, 837.99886), ('parenright', 62.01085999999998, 837.99886), ('parenright', 70.01038, 837.99886), ('quotedblleft', 80.00456, 880.0410999999999), ('quotedblleft', 93.00378, 880.0410999999999), ('quotedblleft', 98.00348, 880.0410999999999), ('quotedblleft', 242.0024, 749.04896), ('quotedblleft', 242.0024, 735.0498), ('quotedblleft', 206.00456, 880.0410999999999), ('quotedblleft', 219.00378, 880.0410999999999), ('quotedblleft', 224.00348, 880.0410999999999), ('quotedblleft', 242.0024, 758.04842), ('quoteleft', 116.0024, 749.04896), ('quoteleft', 116.0024, 735.0498), ('quoteleft', 80.00456, 880.0410999999999), ('quoteleft', 93.00378, 880.0410999999999), ('quoteleft', 98.00348, 880.0410999999999), ('quoteleft', 116.0024, 758.04842)]
    This happens a lot when points are not extremes, which is usually bad. However, fixing this alert by adding points on extremes may do more harm than good, especially with italics, calligraphic-script, handwriting, rounded and other fonts. So it is common to ignore this message

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS
0 16 31 54 16 284
0% 4% 8% 13% 4% 71%

Note: The following loglevels were omitted in this report:

  • SKIP
  • INFO
  • PASS

Diff images: qa.zip

@davelab6 davelab6 merged commit 177d8ea into google:master Jun 12, 2019
@davelab6
Copy link
Member

Merged this as it is a simple hotfix, all other known issues were out of scope for this iteration

@emmamarichal emmamarichal mentioned this pull request Feb 28, 2023
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Life Savers Extra Bold does not exist on google.com/fonts
2 participants
@m4rc1e @davelab6