-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
majormonodisplay: v2.000 added #1710
Conversation
Taken from the upstream repo https://github.com/googlefonts/majormono at commit googlefonts/majormono@ab4221e
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
I've added the description for Major Mono from the README |
Thanks Mike! |
Taken from the upstream repo https://github.com/googlefonts/majormono at commit googlefonts/majormono@ab4221e
Taken from the upstream repo https://github.com/googlefonts/majormono at commit googlefonts/majormono@ab4221e
Taken from the upstream repo https://github.com/googlefonts/majormono at commit googlefonts/majormono@ab4221e
Taken from the upstream repo https://github.com/googlefonts/majormono at commit googlefonts/majormono@ab4221e
FontBakery Report:
Fontbakery report
[2] MajorMonoDisplay-Regular.ttf
💔 ERROR: Version number has increased since previous release on Google Fonts?
🔥 FAIL: Checking with Microsoft Font Validator.
Summary
Note: The following loglevels were omitted in this report:
DiffBrowsers Report:
Imgs
https://drive.google.com/file/d/1lMz8-VXSfXL1lQw0IaDUWJ_l_3-wmnts/view?usp=drivesdk
GFR
http://www.gf-regression.com/compare/ca55b886-a6ff-40fe-82fe-adf2c4423301
Summary
We figured the isfixedpitch FAIL is a false positive, googlefonts/majormono#2 (comment)
@mjlagattuta We need to add a DESCRIPTION.en_us.html file.