Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Averia Serif Libre Roman: v2.000 added #1989

Closed
wants to merge 1 commit into from
Closed

Conversation

eliheuer
Copy link
Collaborator

@gf-bot
Copy link

gf-bot commented May 17, 2019

Fontbakery report

Fontbakery version: 0.7.4

[4] Family checks
💔 ERROR: Directory name in GFonts repo structure must match NameID 1 of the regular.
🔥 FAIL: DESCRIPTION.en_us.html must have less than 1000 bytes.
🔥 FAIL: METADATA.pb: According Google Fonts standards, families should have a Regular style.
WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?

[14] AveriaSerifLibre-Light.ttf
🔥 FAIL: Checking file is named canonically.
  • com.google.fonts/check/canonical_filename
  • 🔥 FAIL This is a variable font, but it is using a naming scheme typical of a static font.
  • 🔥 FAIL Please change the font filename to use one of the following valid suffixes for variable fonts: VF, Italic-VF, Roman-VF
🔥 FAIL: Check glyph coverage.
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb
🔥 FAIL: Copyright notices match canonical pattern in fonts
🔥 FAIL: Copyright field for this font on METADATA.pb matches all copyright notice entries on the name table ?
🔥 FAIL: PPEM must be an integer on hinted fonts.
🔥 FAIL: Check if the vertical metrics of a family are similar to the same family hosted on Google Fonts.
  • com.google.fonts/check/vertical_metrics_regressions
  • 🔥 FAIL Averia Serif Libre Light: OS/2 sTypoAscender is 1830 when it should be 1828
  • 🔥 FAIL Averia Serif Libre Light: OS/2 sTypoDescender is -655 when it should be -465
  • 🔥 FAIL Averia Serif Libre Light: hhea Ascender is 1830 when it should be 1828
  • 🔥 FAIL Averia Serif Libre Light: hhea Descender is -655 when it should be -465
WARN: Checking OS/2 achVendID.
WARN: Font has old ttfautohint applied?
WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?
WARN: Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
WARN: Stricter unitsPerEm criteria for Google Fonts.
  • com.google.fonts/check/unitsperem_strict
  • WARN Even though unitsPerEm (2048) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will likely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations.
WARN: Glyphs are similiar to Google Fonts version?
  • com.google.fonts/check/production_glyphs_similarity
  • WARN Following glyphs differ greatly from Google Fonts version: [Uacute, Acircumflex, odieresis, Edieresis, Idieresis, udieresis, dotlessi, parenright, Otilde, Ocircumflex, Ydieresis, otilde, germandbls, backslash, ecircumflex, nacute, edieresis, icircumflex, idieresis, Zcaron, ntilde, Ucircumflex, ucircumflex, zcaron, yacute, ugrave, Nacute, Atilde, scaron, ocircumflex, Q, Scaron, Icircumflex, onehalf, OE, Adieresis, Egrave, Odieresis, igrave, Ograve, Yacute, Eacute, Agrave, threequarters, Igrave, bar, Ntilde, Oslash, .notdef, section, Aring, aacute]
WARN: Combined length of family and style must not exceed 27 characters.

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS
1 9 8 17 8 113
1% 6% 5% 11% 5% 72%

Note: The following loglevels were omitted in this report:

  • SKIP
  • INFO
  • PASS

Diff images: qa.zip

@eliheuer eliheuer self-assigned this Jun 28, 2019
@eliheuer eliheuer added the III VF Replacement Replace an existing family of static fonts with variable fonts label Jun 28, 2019
@gf-bot
Copy link

gf-bot commented Jul 17, 2019

Fontbakery report

Fontbakery version: 0.7.9

[3] Family checks
💔 ERROR: Does METADATA.pb copyright field contain broken links?
🔥 FAIL: METADATA.pb: According Google Fonts standards, families should have a Regular style.
WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?

[16] AveriaSerifLibre[wght].ttf
🔥 FAIL: Checking file is named canonically.
  • com.google.fonts/check/canonical_filename
  • 🔥 FAIL The file 'AveriaSerifLibre[wght].ttf' must be renamed to 'AveriaSerifLibreLight[wght].ttf' according to the Google Fonts naming policy for variable fonts.
🔥 FAIL: Does DESCRIPTION file contain a upstream Git repo URL?
🔥 FAIL: Does DESCRIPTION file mention when a family is available as variable font?
  • com.google.fonts/check/description/variable_font
  • 🔥 FAIL Please mention in the DESCRIPTION.en-us.html that the family is a variable font. This check expects the words 'variable font' to be present in the text e.g 'This font is now available as a variable font.'
🔥 FAIL: DESCRIPTION.en_us.html must have less than 1000 bytes.
🔥 FAIL: Check glyph coverage.
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb
🔥 FAIL: Copyright notices match canonical pattern in fonts
🔥 FAIL: METADATA.pb: Filename is set canonically?
🔥 FAIL: Copyright field for this font on METADATA.pb matches all copyright notice entries on the name table ?
🔥 FAIL: PPEM must be an integer on hinted fonts.
WARN: Checking OS/2 achVendID.
WARN: Font has old ttfautohint applied?
WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?
WARN: Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
WARN: Stricter unitsPerEm criteria for Google Fonts.
  • com.google.fonts/check/unitsperem_strict
  • WARN Even though unitsPerEm (2048) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will likely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations.
WARN: Combined length of family and style must not exceed 27 characters.

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS
1 11 7 36 8 96
1% 7% 4% 23% 5% 60%

Note: The following loglevels were omitted in this report:

  • SKIP
  • INFO
  • PASS

Diff images: qa.zip

@gf-bot
Copy link

gf-bot commented Sep 13, 2019

Fontbakery report

Fontbakery version: 0.7.11

[1] Family checks
WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?

[8] AveriaSerifLibre[wght].ttf
🔥 FAIL: Checking file is named canonically.
  • com.google.fonts/check/canonical_filename
  • 🔥 FAIL The file 'AveriaSerifLibre[wght].ttf' must be renamed to 'AveriaSerifLibreLight[wght].ttf' according to the Google Fonts naming policy for variable fonts. [code: bad-varfont-filename]
🔥 FAIL: Check glyph coverage.
  • com.google.fonts/check/glyph_coverage
  • 🔥 FAIL Missing required codepoints: 0x000D (CARRIAGE RETURN), 0x2074 (SUPERSCRIPT FOUR) and 0x2215 (DIVISION SLASH) [code: missing-codepoints]
🔥 FAIL: Copyright notices match canonical pattern in fonts
  • com.google.fonts/check/font_copyright
  • 🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: "Copyright 2019 The Familyname Project Authors (git url)"
    But instead we have got:
    "Copyright (c) 2011, Dan Sayers ([email protected])" [code: bad-notice-format]
🔥 FAIL: PPEM must be an integer on hinted fonts.

This can be accomplished by using the 'gftools fix-hinting' command.

create virtualenvpython3 -m venv venv

activate virtualenvsource venv/bin/activate

install gftoolspip install git+https://www.github.com/googlefonts/tools [code: bad-flags]

WARN: Checking OS/2 achVendID.
WARN: Font has old ttfautohint applied?
WARN: Stricter unitsPerEm criteria for Google Fonts.
  • com.google.fonts/check/unitsperem_strict
  • WARN Even though unitsPerEm (2048) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will likely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations. [code: legacy-value]
WARN: Combined length of family and style must not exceed 27 characters.

Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]


Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS
0 4 5 76 7 68
0% 2% 3% 48% 4% 42%

Note: The following loglevels were omitted in this report:

  • SKIP
  • INFO
  • PASS

Diff images: qa.zip

@m4rc1e
Copy link
Collaborator

m4rc1e commented Sep 13, 2019

Quite a few missing kerns.

kerns_missing

Were the metrics consistent across the original family? we have shifted vert metrics

Desktop_Windows_10_chrome_69 0_

Run gftools fix-nonhinting on the fonts as well.

@eliheuer please fix the above

@m4rc1e
Copy link
Collaborator

m4rc1e commented Nov 6, 2019

ping @eliheuer

Base automatically changed from master to main February 26, 2021 16:09
@RosaWagner RosaWagner added -- Needs manager's opinion from upper level I Font Upgrade -- Needs Upstream Resolution Upstream fix required before moving forward -- Regressions Shows diff with previous published version and removed III VF Replacement Replace an existing family of static fonts with variable fonts -- Needs manager's opinion from upper level labels Apr 7, 2021
@RosaWagner RosaWagner closed this Sep 30, 2021
@m4rc1e m4rc1e deleted the averia-serif-roman branch October 9, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-- Needs Upstream Resolution Upstream fix required before moving forward -- Regressions Shows diff with previous published version I Font Upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants