Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public Sans Italic: v1.006 added #2010

Closed
wants to merge 2 commits into from
Closed

Conversation

eliheuer
Copy link
Collaborator

@eliheuer eliheuer commented Jun 7, 2019

From the upstream repo: https://github.com/uswds/public-sans
At commit: 4c9f0fab4659bcab309fe3ab03abe45be704b108

@gf-bot
Copy link

gf-bot commented Jun 7, 2019

Fontbakery report

Fontbakery version: 0.7.5

[2] Family checks
🔥 FAIL: Check METADATA.pb parse correctly.
WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?

[24] PublicSans-ThinItalic.ttf
🔥 FAIL: Checking file is named canonically.
🔥 FAIL: Check glyph coverage.
🔥 FAIL: Checking OS/2 usWeightClass.
🔥 FAIL: Is 'gasp' table set to optimize rendering?
🔥 FAIL: Checking OS/2 fsSelection value.
  • com.google.fonts/check/fsselection
  • 🔥 FAIL OS/2 fsSelection REGULAR bit should be reset. [code: bad-REGULAR]
  • 🔥 FAIL OS/2 fsSelection ITALIC bit should be set. [code: bad-ITALIC]
🔥 FAIL: Checking head.macStyle value.
🔥 FAIL: Font has all mandatory 'name' table entries ?
🔥 FAIL: Check name table: FONT_FAMILY_NAME entries.
  • com.google.fonts/check/name/familyname
  • 🔥 FAIL Entry [FONT_FAMILY_NAME(1):MACINTOSH(1)] on the 'name' table: Expected 'Public Sans' but got 'Public Sans Italic VF'.
  • 🔥 FAIL Entry [FONT_FAMILY_NAME(1):WINDOWS(3)] on the 'name' table: Expected 'Public Sans Thin' but got 'Public Sans Italic VF'.
🔥 FAIL: Check name table: FONT_SUBFAMILY_NAME entries.
  • com.google.fonts/check/name/subfamilyname
  • 🔥 FAIL Entry [FONT_SUBFAMILY_NAME(2):MACINTOSH(1)] on the 'name' table: Expected 'Thin Italic' but got 'Regular'. [code: bad-familyname]
  • 🔥 FAIL Entry [FONT_SUBFAMILY_NAME(2):WINDOWS(3)] on the 'name' table: Expected 'Italic' but got 'Regular'. [code: bad-familyname]
🔥 FAIL: Check name table: FULL_FONT_NAME entries.
  • com.google.fonts/check/name/fullfontname
  • 🔥 FAIL Entry [FULL_FONT_NAME(4):MACINTOSH(1)] on the 'name' table: Expected 'Public Sans Thin Italic' but got 'Public Sans Italic VF'.
  • 🔥 FAIL Entry [FULL_FONT_NAME(4):WINDOWS(3)] on the 'name' table: Expected 'Public Sans Thin Italic' but got 'Public Sans Italic VF'.
🔥 FAIL: Check name table: POSTSCRIPT_NAME entries.
  • com.google.fonts/check/name/postscriptname
  • 🔥 FAIL Entry [POSTSCRIPT_NAME(6):MACINTOSH(1)] on the 'name' table: Expected 'PublicSans-ThinItalic' but got 'PublicSansItalicVF'.
  • 🔥 FAIL Entry [POSTSCRIPT_NAME(6):WINDOWS(3)] on the 'name' table: Expected 'PublicSans-ThinItalic' but got 'PublicSansItalicVF'.
🔥 FAIL: Check name table: TYPOGRAPHIC_FAMILY_NAME entries.
🔥 FAIL: Check name table: TYPOGRAPHIC_SUBFAMILY_NAME entries.
🔥 FAIL: Check that variable fonts have an HVAR table.
  • com.google.fonts/check/varfont/has_HVAR
  • 🔥 FAIL All variable fonts on the Google Fonts collection must have a properly set HVAR table in order to avoid costly text-layout operations on certain platforms.
🔥 FAIL: Font enables smart dropout control in "prep" table instructions?
  • com.google.fonts/check/smart_dropout
  • 🔥 FAIL 'prep' table does not contain TrueType instructions enabling smart dropout control. To fix, export the font with autohinting enabled, or run ttfautohint on the font, or run the gftools fix-nonhinting script.
🔥 FAIL: Variable font weight coordinates must be multiples of 100.
  • com.google.fonts/check/varfont_weight_instances
  • 🔥 FAIL Found an variable font instance with 'wght'=220.0. This should instead be a multiple of 100.
  • 🔥 FAIL Found an variable font instance with 'wght'=375.0. This should instead be a multiple of 100.
  • 🔥 FAIL Found an variable font instance with 'wght'=450.0. This should instead be a multiple of 100.
  • 🔥 FAIL Found an variable font instance with 'wght'=525.0. This should instead be a multiple of 100.
  • 🔥 FAIL Found an variable font instance with 'wght'=650.0. This should instead be a multiple of 100.
  • 🔥 FAIL Found an variable font instance with 'wght'=775.0. This should instead be a multiple of 100.
🔥 FAIL: Checking OS/2 usWinAscent & usWinDescent.
  • com.google.fonts/check/family/win_ascent_and_descent
  • 🔥 FAIL OS/2.usWinAscent value should be equal or greater than 2078, but got 2038 instead [code: ascent]
  • 🔥 FAIL OS/2.usWinDescent value should be equal or greater than 555, but got 451 instead [code: descent]
🔥 FAIL: Checking OS/2 Metrics match hhea Metrics.
WARN: Checking OS/2 achVendID.
WARN: Stricter unitsPerEm criteria for Google Fonts.
  • com.google.fonts/check/unitsperem_strict
  • WARN Even though unitsPerEm (2048) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will likely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations.
WARN: Are there caret positions declared for every ligature?
WARN: Is there kerning info for non-ligated sequences?
  • com.google.fonts/check/kerning_for_non_ligated_sequences

  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • space + emdash
    • emdash + space
    • f + i
    • i + l
    • colon + f
    • f + l
    • l + a
    • a + g
    • g + two
    • two + colon
    • g + colon
    • colon + one
    • one + eight
    • eight + F
    • F + colon

    [code: lacks-kern-info]

WARN: Combined length of family and style must not exceed 27 characters.
WARN: Check for points out of bounds.
  • com.google.fonts/check/points_out_of_bounds
  • WARN The following glyphs have coordinates which are out of bounds:
    [('uni020A', 642.3394499999999, 1629.0), ('uni020B', 563.3394499999999, 1207.0), ('uni0213', 715.3394499999999, 1207.0), ('zero.subs', 254.59423000000004, 596.08397), ('zero.subs', 339.50518, 596.08397), ('zero.subs', 425.04510000000005, 596.08397), ('zero.subs', 575.36893, 274.05133), ('one.subs', 275.49509, 593.5045700000001), ('two.subs', 240.53071, 606.08397), ('two.subs', 324.81269000000003, 606.08397), ('two.subs', 400.28909000000004, 606.08397), ('two.subs', 553.1288000000001, 431.23031000000003), ('three.subs', -26.311369999999997, -172.92015999999998), ('three.subs', 289.43157, 600.08397), ('three.subs', 361.13415000000003, 600.08397), ('three.subs', 442.27128000000005, 600.08397), ('three.subs', 610.20627, 438.4386800000001), ('five.subs', -39.3927, -99.33067), ('five.subs', 603.4146400000001, 587.5045700000001), ('six.subs', 594.23803, 391.66872), ('seven.subs', 38.631339999999994, 541.92903), ('eight.subs', 160.12169, -345.25794), ('eight.subs', -29.198279999999997, -162.22767), ('eight.subs', 309.81655, 605.1157300000001), ('eight.subs', 386.55089000000004, 605.1157300000001), ('eight.subs', 463.28523000000007, 605.1157300000001), ('eight.subs', 631.22022, 435.29383000000007), ('eight.subs', 345.66784, -345.25794), ('eight.subs', 252.58028000000002, -345.25794), ('zero.dnom', 312.59423000000004, 934.08397), ('zero.dnom', 397.50518, 934.08397), ('zero.dnom', 483.04510000000005, 934.08397), ('zero.dnom', 633.36893, 612.05133), ('one.dnom', 335.49509, 931.5045700000001), ('two.dnom', 301.53071, 944.08397), ('two.dnom', 385.81269000000003, 944.08397), ('two.dnom', 461.28909000000004, 944.08397), ('two.dnom', 614.1288000000001, 769.23031), ('three.dnom', 20.688630000000003, 165.07984000000002), ('three.dnom', 336.43157, 938.08397), ('three.dnom', 408.13415000000003, 938.08397), ('three.dnom', 489.27128000000005, 938.08397), ('three.dnom', 657.20627, 776.4386800000001), ('five.dnom', 18.607300000000002, 238.66933), ('five.dnom', 661.4146400000001, 925.5045700000001), ('six.dnom', 652.23803, 729.66872), ('seven.dnom', 99.63134, 879.92903), ('eight.dnom', 208.12169, -9.25794), ('eight.dnom', 18.801720000000003, 173.77233), ('eight.dnom', 357.81655, 941.1157300000001), ('eight.dnom', 434.55089000000004, 941.1157300000001), ('eight.dnom', 511.28523000000007, 941.1157300000001), ('eight.dnom', 679.22022, 771.2938300000001), ('eight.dnom', 393.66784, -9.25794), ('eight.dnom', 300.58028, -9.25794), ('zero.numr', 393.59423000000004, 1515.0839700000001), ('zero.numr', 478.50518, 1515.0839700000001), ('zero.numr', 564.0451, 1515.0839700000001), ('zero.numr', 714.36893, 1193.05133), ('one.numr', 414.49509, 1496.50457), ('two.numr', 381.53071, 1515.0839700000001), ('two.numr', 465.81269000000003, 1515.0839700000001), ('two.numr', 541.28909, 1515.0839700000001), ('two.numr', 694.1288000000001, 1340.23031), ('three.numr', 101.68863, 742.07984), ('three.numr', 417.43157, 1515.0839700000001), ('three.numr', 489.13415000000003, 1515.0839700000001), ('three.numr', 570.27128, 1515.0839700000001), ('three.numr', 738.20627, 1353.4386800000002), ('five.numr', 98.60730000000001, 809.66933), ('five.numr', 741.4146400000001, 1496.50457), ('six.numr', 734.23803, 1312.6687200000001), ('seven.numr', 178.63134, 1442.92903), ('eight.numr', 290.12169, 569.74206), ('eight.numr', 100.80172, 752.77233), ('eight.numr', 439.81655, 1520.11573), ('eight.numr', 516.55089, 1520.11573), ('eight.numr', 593.2852300000001, 1520.11573), ('eight.numr', 761.22022, 1350.29383), ('eight.numr', 475.66784, 569.74206), ('eight.numr', 382.58028, 569.74206), ('uni2070', 423.59423000000004, 1728.0839700000001), ('uni2070', 508.50518, 1728.0839700000001), ('uni2070', 594.0451, 1728.0839700000001), ('uni2070', 744.36893, 1406.05133), ('uni00B9', 444.49509, 1709.50457), ('uni00B2', 411.53071, 1730.0839700000001), ('uni00B2', 495.81269000000003, 1730.0839700000001), ('uni00B2', 571.28909, 1730.0839700000001), ('uni00B2', 724.1288000000001, 1555.23031), ('uni00B3', 131.68863, 957.07984), ('uni00B3', 447.43157, 1730.0839700000001), ('uni00B3', 519.1341500000001, 1730.0839700000001), ('uni00B3', 600.27128, 1730.0839700000001), ('uni00B3', 768.20627, 1568.4386800000002), ('uni2075', 128.6073, 1022.66933), ('uni2075', 771.4146400000001, 1709.50457), ('uni2076', 764.23803, 1527.6687200000001), ('uni2077', 208.63134, 1657.92903), ('uni2078', 320.12169, 784.74206), ('uni2078', 130.80172, 967.77233), ('uni2078', 469.81655, 1735.11573), ('uni2078', 546.55089, 1735.11573), ('uni2078', 623.2852300000001, 1735.11573), ('uni2078', 791.22022, 1565.29383), ('uni2078', 505.66784, 784.74206), ('uni2078', 412.58028, 784.74206), ('onehalf', 1503.1288, 769.23031), ('uni2153', 1476.2062700000001, 776.4386800000001), ('uni2154', 381.53071, 1515.0839700000001), ('uni2154', 465.81269000000003, 1515.0839700000001), ('uni2154', 541.28909, 1515.0839700000001), ('uni2154', 1746.2062700000001, 776.4386800000001), ('threequarters', 101.68863, 742.07984), ('threequarters', 417.43157, 1515.0839700000001), ('threequarters', 489.13415000000003, 1515.0839700000001), ('threequarters', 570.27128, 1515.0839700000001), ('oneeighth', 1027.12169, -9.25794), ('oneeighth', 1498.2202200000002, 771.2938300000001), ('oneeighth', 1212.66784, -9.25794), ('oneeighth', 1119.5802800000001, -9.25794), ('threeeighths', 101.68863, 742.07984), ('threeeighths', 417.43157, 1515.0839700000001), ('threeeighths', 489.13415000000003, 1515.0839700000001), ('threeeighths', 570.27128, 1515.0839700000001), ('threeeighths', 1257.12169, -9.25794), ('threeeighths', 1728.2202200000002, 771.2938300000001), ('threeeighths', 1442.66784, -9.25794), ('threeeighths', 1349.5802800000001, -9.25794), ('fiveeighths', 98.60730000000001, 809.66933), ('fiveeighths', 1250.12169, -9.25794), ('fiveeighths', 1721.2202200000002, 771.2938300000001), ('fiveeighths', 1435.66784, -9.25794), ('fiveeighths', 1342.5802800000001, -9.25794), ('seveneighths', 1062.12169, -9.25794), ('seveneighths', 1533.2202200000002, 771.2938300000001), ('seveneighths', 1247.66784, -9.25794), ('seveneighths', 1154.5802800000001, -9.25794), ('trademark', 1657.375, 925.625), ('uni2120', 242.375, -12.5), ('uni2120', 418.0, -12.5), ('uni2120', 320.5, -12.5), ('uni2120', 1807.375, 925.625), ('uni0311', 90.33945, 1207.0)]
    This happens a lot when points are not extremes, which is usually bad. However, fixing this alert by adding points on extremes may do more harm than good, especially with italics, calligraphic-script, handwriting, rounded and other fonts. So it is common to ignore this message

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS
0 19 7 56 6 67
0% 12% 5% 36% 4% 43%

Note: The following loglevels were omitted in this report:

  • SKIP
  • INFO
  • PASS

Diff images: qa.zip

@eliheuer eliheuer self-assigned this Jun 28, 2019
@eliheuer eliheuer changed the title Public Sans Italic: v1.005 added Public Sans Italic: v1.006 added Oct 23, 2019
Upstream repo: https://github.com/eliheuer/public-sans/tree/gf-pr
At commit: 3428a423411a3b8bb10f606a7df2db6ad2663349
@gf-bot
Copy link

gf-bot commented Oct 23, 2019

Fontbakery report

Fontbakery version: 0.7.14

[1] Family checks
WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?

[6] PublicSans-Italic[wght].ttf
🔥 FAIL: Copyright notices match canonical pattern in fonts
  • com.google.fonts/check/font_copyright
  • 🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: "Copyright 2019 The Familyname Project Authors (git url)"
    But instead we have got:
    "Copyright (c) 2015, Impallari Type (www.impallari.com)" [code: bad-notice-format]
🔥 FAIL: Variable font weight coordinates must be multiples of 100.
  • com.google.fonts/check/varfont_weight_instances
  • 🔥 FAIL Found a variable font instance with 'wght'=250.0. This should instead be a multiple of 100. [code: bad-coordinate]
  • 🔥 FAIL Found a variable font instance with 'wght'=275.0. This should instead be a multiple of 100. [code: bad-coordinate]
🔥 FAIL: Check variable font instances have correct coordinate values
  • com.google.fonts/check/varfont_instance_coordinates
  • 🔥 FAIL Instance "Thin Italic" wght value is "250.0". It should be "100.0" [code: bad-coordinate]
  • 🔥 FAIL Instance "ExtraLight Italic" wght value is "275.0". It should be "200.0" [code: bad-coordinate]
WARN: Checking OS/2 achVendID.
WARN: Are there caret positions declared for every ligature?
WARN: Is there kerning info for non-ligated sequences?

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 3 4 76 7 71 0
0% 2% 2% 47% 4% 44% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • INFO
  • PASS
  • DEBUG

Diff images: qa.zip

Upstream repo: https://github.com/eliheuer/public-sans/tree/gf-pr
At commit: 0fa34c0f72c989afc5d584874bb351e802fca380
@gf-bot
Copy link

gf-bot commented Oct 23, 2019

Fontbakery report

Fontbakery version: 0.7.14

[1] Family checks
WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?

[5] PublicSans-Italic[wght].ttf
🔥 FAIL: Copyright notices match canonical pattern in fonts
  • com.google.fonts/check/font_copyright
  • 🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: "Copyright 2019 The Familyname Project Authors (git url)"
    But instead we have got:
    "Copyright (c) 2015, Impallari Type (www.impallari.com)" [code: bad-notice-format]
WARN: Checking OS/2 achVendID.
WARN: Checking OS/2 usWeightClass.
  • com.google.fonts/check/usweightclass
  • WARN Thin Italic:100 is OK on TTFs, but OTF files with those values will cause bluring on Windows. GlyphsApp users must set an Instance Custom Parameter for the Thin and ExtraLight styles to 250 and 275, so that if OTFs are exported then it will not blur on Windows. [code: blur-on-windows]
WARN: Are there caret positions declared for every ligature?
WARN: Is there kerning info for non-ligated sequences?

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 1 5 76 7 72 0
0% 1% 3% 47% 4% 45% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • INFO
  • PASS
  • DEBUG

Diff images: qa.zip

@eliheuer
Copy link
Collaborator Author

eliheuer commented Oct 24, 2019

@m4rc1e Please feel free to close this and merge it with PR #2009, or I can just do that, whatever is easier for you.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Oct 25, 2019

Closing. #2009 now has the Italic VF.

@m4rc1e m4rc1e closed this Oct 25, 2019
@m4rc1e m4rc1e deleted the publicsans-italic-vf branch May 18, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants