Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gulzar: Version 1.000;[57fe3b0]; ttfautohint (v1.8.4) added #4674

Merged
merged 6 commits into from
May 18, 2022

Conversation

simoncozens
Copy link
Collaborator

@simoncozens simoncozens commented May 14, 2022

9a986e6: [gftools-packager] Gulzar: Version 1.000;[57fe3b0]; ttfautohint (v1.8.4) added

closes #4367

….4) added

* Gulzar Version 1.000;[57fe3b0]; ttfautohint (v1.8.4) taken from the upstream repo https://github.com/simoncozens/Gulzar at commit googlefonts/Gulzar@7f73671.
@simoncozens simoncozens mentioned this pull request May 14, 2022
9 tasks
@gf-bot

This comment was marked as outdated.

@gf-bot

This comment was marked as outdated.

@simoncozens
Copy link
Collaborator Author

U+02BC is not part of GF Latin Core, so add-font is doing something wrong, but I will remove those languages from the METADATA.

@gf-bot

This comment was marked as outdated.

@simoncozens
Copy link
Collaborator Author

Arabic subset was not detected because we don't have the presentation form glyphs. I'll add it manually to METADATA, as well as crediting two more designers.

@gf-bot

This comment was marked as outdated.

@RosaWagner
Copy link
Contributor

all languages should be removed from metadata.pb (except for Noto), they do that in prod now. (gftools has been upgraded accordingly)

@gf-bot
Copy link

gf-bot commented May 18, 2022

Fontbakery report

Fontbakery version: 0.8.8

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[21] Gulzar-Regular.ttf
WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f
    • f + b
    • b + f
    • f + h
    • h + f
    • f + i
    • i + f
    • f + j
    • j + f
    • f + k
    • k + f
    • f + l
    • l + b
    • h + i
    • i + j
    • j + k
    • k + l

    [code: lacks-kern-info]

WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • WARN It seems that Alice Savoie is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
  • WARN It seems that Simon Cozens is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Font contains '.notdef' as its first glyph? (com.google.fonts/check/mandatory_glyphs)
  • WARN Glyph '.notdef' should contain a drawing, but it is empty. [code: empty]
WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This font has a 'Soft Hyphen' character (codepoint 0x00AD) which is supposed to be zero-width and invisible, and is used to mark a hyphenation possibility within a word in the absence of or overriding dictionary hyphenation. It is mostly an obsolete mechanism now, and the character is only included in fonts for legacy codepage coverage. [code: softhyphen]
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: uni00AD	Contours detected: 1	Expected: 0 
- And Glyph name: uni00AD	Contours detected: 1	Expected: 0

[code: contour-count]

WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
WARN: Font has correct post table version? (com.google.fonts/check/post_table_version)
  • WARN Post table format 3 use has niche use case problems.Please review the check rationale for additional details. [code: post-table-version]
WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
  • WARN The following mark characters could be in the GDEF mark glyph class:
    uni0657 (U+0657) [code: mark-chars]
WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
  • WARN The following glyphs have colinear vectors:
    • M (U+004D): L<<99.0,81.0>--<134.0,621.0>> -> L<<134.0,621.0>--<134.0,630.0>>
    • N (U+004E): L<<618.0,598.0>--<610.0,74.0>> -> L<<610.0,74.0>--<610.0,0.0>>
    • Ntilde (U+00D1): L<<618.0,598.0>--<610.0,74.0>> -> L<<610.0,74.0>--<610.0,0.0>>
    • OE (U+0152): L<<471.0,675.0>--<471.0,675.0>> -> L<<471.0,675.0>--<982.0,675.0>>
    • a (U+0061): L<<285.0,79.0>--<285.0,84.0>> -> L<<285.0,84.0>--<285.0,212.0>>
    • aacute (U+00E1): L<<285.0,79.0>--<285.0,84.0>> -> L<<285.0,84.0>--<285.0,212.0>>
    • acircumflex (U+00E2): L<<285.0,79.0>--<285.0,84.0>> -> L<<285.0,84.0>--<285.0,212.0>>
    • adieresis (U+00E4): L<<285.0,79.0>--<285.0,84.0>> -> L<<285.0,84.0>--<285.0,212.0>>
    • agrave (U+00E0): L<<285.0,79.0>--<285.0,84.0>> -> L<<285.0,84.0>--<285.0,212.0>>
    • amacron (U+0101): L<<285.0,79.0>--<285.0,84.0>> -> L<<285.0,84.0>--<285.0,212.0>> and 25 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-colinear-vectors]

WARN: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
  • WARN The following glyphs have jaggy segments:
    • at (U+0040): L<<571.0,153.0>--<580.0,213.0>>/B<<580.0,213.0>-<570.0,182.0>-<553.5,143.5>> = 9.347930985893194
    • braceleft (U+007B): B<<213.0,301.5>-<188.0,282.0>-<141.0,276.0>>/B<<141.0,276.0>-<188.0,271.0>-<213.0,251.5>> = 13.347461365096933
    • braceright (U+007D): B<<158.0,251.5>-<183.0,271.0>-<230.0,277.0>>/B<<230.0,277.0>-<183.0,282.0>-<158.0,301.5>> = 13.347461365096933
    • uniFD3E (U+FD3E): B<<270.0,117.0>-<278.0,122.0>-<278.0,131.0>>/B<<278.0,131.0>-<279.0,122.0>-<287.5,117.0>> = 6.340191745909908
    • uniFD3F (U+FD3F): B<<324.5,117.0>-<333.0,122.0>-<334.0,131.0>>/B<<334.0,131.0>-<334.0,122.0>-<342.0,117.0>> = 6.340191745909908 and uniFDFB (U+FDFB): L<<551.0,283.0>--<553.0,7.0>>/L<<553.0,7.0>--<553.0,9.0>> = 0.4151795411446551 [code: found-jaggy-segments]
WARN: Do outlines contain any semi-vertical or semi-horizontal lines? (com.google.fonts/check/outline_semi_vertical)
  • WARN The following glyphs have semi-vertical/semi-horizontal lines:
  • uni0644 (U+0644): L<<701.0,884.0>--<703.0,358.0>>
  • uniFDFB (U+FDFB): L<<551.0,283.0>--<553.0,7.0>> and uniFDFC (U+FDFC): L<<721.0,753.0>--<723.0,227.0>> [code: found-semi-vertical]
INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/gulzar/Gulzar-Regular.ttf
Dehinted Size 852.9kb
Hinted Size 940.9kb
Increase 88.0kb
Change 10.3 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.000;[7b34f74]; ttfautohint (v1.8.4)"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
  • INFO No sample_glyphs on METADATA.pb [code: no-samples]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:
    • cvt
    • fpgm
    • loca
    • prep
    • GPOS
    • GSUB
    • And gasp [code: optional-tables]
INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/gulzar [code: family-path]
INFO: Check if OS/2 xAvgCharWidth is correct. (com.google.fonts/check/xavgcharwidth)

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 0 12 55 10 148 0
0% 0% 5% 24% 4% 66% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner RosaWagner merged commit deb08df into main May 18, 2022
@RosaWagner RosaWagner deleted the gftools_packager_ofl_gulzar branch May 18, 2022 14:51
@RosaWagner RosaWagner added II Arabic / Hebrew / Semitic / RTL Middle-east and afro-asian RTL scripts and removed II Commissioned Commissioned project to do labels May 27, 2022
@RosaWagner RosaWagner added --- to production --- Live Font is visible on API and removed --- to sandbox labels Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--- Live Font is visible on API I New Font II Arabic / Hebrew / Semitic / RTL Middle-east and afro-asian RTL scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Gulzar
3 participants