Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADLaM Display: Version 2.000; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.28] added #6522

Merged
merged 3 commits into from
Jul 21, 2023

Conversation

aaronbell
Copy link
Collaborator

4069951: [gftools-packager] ADLaM Display: Version 2.000; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.28] added

…7-5d5b);gftools[0.9.28] added

* ADLaM Display Version 2.000; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.28] taken from the upstream repo https://github.com/microsoft/ADLaM-Display at commit microsoft/ADLaM-Display@8791762.
@github-actions
Copy link

Fontbakery report

Fontbakery version: 0.8.13

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[29] ADLaMDisplay-Regular.ttf
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
  • 🔥 FAIL Missing required codepoints:

    • 0x0102 (LATIN CAPITAL LETTER A WITH BREVE)

    • 0x0100 (LATIN CAPITAL LETTER A WITH MACRON)

    • 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)

    • 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)

    • 0x010C (LATIN CAPITAL LETTER C WITH CARON)

    • 0x010A (LATIN CAPITAL LETTER C WITH DOT ABOVE)

    • 0x010E (LATIN CAPITAL LETTER D WITH CARON)

    • 0x0110 (LATIN CAPITAL LETTER D WITH STROKE)

    • 0x011A (LATIN CAPITAL LETTER E WITH CARON)

    • 0x0116 (LATIN CAPITAL LETTER E WITH DOT ABOVE)

    • 96 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)
  • 🔥 FAIL First line in license file is:

"copyright (c) 2022 by microsoft. all rights reserved."

which does not match the expected format, similar to:

"Copyright 2022 The Familyname Project Authors (git url)" [code: bad-format]

🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)
  • 🔥 FAIL METADATA.pb: Copyright notices should match a pattern similar to:
    "Copyright 2020 The Familyname Project Authors (git url)"
    But instead we have got:
    "copyright (c) 2022 by microsoft. all rights reserved." [code: bad-notice-format]
🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)
  • 🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: "Copyright 2019 The Familyname Project Authors (git url)"
    But instead we have got:
    "Copyright (c) 2022 by Microsoft. All rights reserved." [code: bad-notice-format]
🔥 FAIL: Check family name for GF Guide compliance. (com.google.fonts/check/name/family_name_compliance)
  • 🔥 FAIL "ADLaM Display" contains an abbreviation. [code: abbreviation]
🔥 FAIL: Checking with fontTools.ttx (com.google.fonts/check/ttx_roundtrip)
  • 🔥 FAIL name id 256 missing from name table
  • INFO While converting TTF into an XML file, ttx emited the messages listed below.
🔥 FAIL: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • 🔥 FAIL No dotted circle glyph presentand font uses a complex shaper [code: missing-dotted-circle-complex]
WARN: URLs on DESCRIPTION file must not display http(s) prefix. (com.google.fonts/check/description/urls)
WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
  • WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: yi, tifinagh, canadian-aboriginal

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: math, tifinagh, coptic, cherokee

  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic

  • U+0307 COMBINING DOT ABOVE: try adding one of: coptic, math, tifinagh, canadian-aboriginal, syriac, tai-le, malayalam, old-permic

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee

  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
    13 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu [code: unreachable-subsetting]

WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + i

    • i + l [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • WARN It seems that Mark Jamra is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
  • WARN It seems that Neil Patel is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
  • WARN It seems that Andrew Footit is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • NULL
      [code: unreachable-glyphs]
WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: V	Contours detected: 3	Expected: 1

- Glyph name: W	Contours detected: 3	Expected: 1 or 2

- Glyph name: v	Contours detected: 3	Expected: 1

- Glyph name: w	Contours detected: 3	Expected: 1

- Glyph name: y	Contours detected: 3	Expected: 1

- Glyph name: uni00AD	Contours detected: 1	Expected: 0

- Glyph name: yacute	Contours detected: 4	Expected: 2

- Glyph name: ydieresis	Contours detected: 5	Expected: 3

- Glyph name: V	Contours detected: 3	Expected: 1

- Glyph name: W	Contours detected: 3	Expected: 1 or 2 

- 6 more.

Use -F or --full-lists to disable shortening of long lists.
[code: contour-count]

WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
  • WARN This font has a 'Soft Hyphen' character. [code: softhyphen]
WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 1434 among a set of 6 math glyphs.
    The following math glyphs have a different width, though:

Width = 1414:
greater, less

Width = 1430:
plusminus

Width = 1442:
multiply

Width = 1566:
approxequal

Width = 1432:
greaterequal, lessequal
[code: width-outliers]

WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
  • WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:

    • dollar (U+0024): X=515.0,Y=1.0 (should be at baseline 0?)

    • dollar (U+0024): X=661.0,Y=1432.0 (should be at cap-height 1434?)

    • percent (U+0025): X=564.0,Y=-1.0 (should be at baseline 0?)

    • colon (U+003A): X=289.0,Y=-1.0 (should be at baseline 0?)

    • C (U+0043): X=967.5,Y=-2.0 (should be at baseline 0?)

    • G (U+0047): X=1067.0,Y=-1.0 (should be at baseline 0?)

    • S (U+0053): X=337.5,Y=-1.0 (should be at baseline 0?)

    • c (U+0063): X=841.0,Y=-1.0 (should be at baseline 0?)

    • d (U+0064): X=665.5,Y=-2.0 (should be at baseline 0?)

    • ordfeminine (U+00AA): X=250.5,Y=1432.0 (should be at cap-height 1434?)

    • 30 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
  • WARN The following glyphs have colinear vectors:

    • V (U+0056): L<<1348.0,1274.0>--<1348.0,1275.0>> -> L<<1348.0,1275.0>--<1348.0,1277.0>>

    • V (U+0056): L<<60.0,1278.0>--<60.0,1277.0>> -> L<<60.0,1277.0>--<60.0,1274.0>>

    • W (U+0057): L<<60.0,1281.0>--<60.0,1280.0>> -> L<<60.0,1280.0>--<60.0,1277.0>>

    • fraction (U+2044): L<<-115.0,148.0>--<650.0,1383.0>> -> L<<650.0,1383.0>--<675.0,1423.0>>

    • fraction (U+2044): L<<-140.0,108.0>--<-115.0,148.0>> -> L<<-115.0,148.0>--<650.0,1383.0>>

    • fraction (U+2044): L<<827.0,1273.0>--<60.0,39.0>> -> L<<60.0,39.0>--<35.0,-1.0>>

    • fraction (U+2044): L<<852.0,1313.0>--<827.0,1273.0>> -> L<<827.0,1273.0>--<60.0,39.0>>

    • onehalf (U+00BD): L<<1528.0,1273.0>--<761.0,39.0>> -> L<<761.0,39.0>--<736.0,-1.0>>

    • onehalf (U+00BD): L<<1553.0,1313.0>--<1528.0,1273.0>> -> L<<1528.0,1273.0>--<761.0,39.0>>

    • onehalf (U+00BD): L<<561.0,108.0>--<586.0,148.0>> -> L<<586.0,148.0>--<1351.0,1383.0>>

    • 20 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-colinear-vectors]

WARN: Do outlines contain any semi-vertical or semi-horizontal lines? (com.google.fonts/check/outline_semi_vertical)
  • WARN The following glyphs have semi-vertical/semi-horizontal lines:

    • L (U+004C): L<<597.0,262.0>--<904.0,263.0>>

    • Z (U+005A): L<<482.0,262.0>--<1107.0,263.0>>

    • Zcaron (U+017D): L<<482.0,262.0>--<1107.0,263.0>>

    • u (U+0075): L<<136.0,406.0>--<135.0,914.0>>

    • u1E901 (U+1E901): L<<131.0,964.0>--<130.0,1274.0>>

    • u1E901 (U+1E901): L<<453.0,1274.0>--<454.0,1056.0>>

    • u1E903 (U+1E903): L<<893.0,855.0>--<892.0,1049.0>>

    • u1E905 (U+1E905): L<<1384.0,424.0>--<1387.0,1037.0>>

    • u1E911 (U+1E911): L<<1426.0,1166.0>--<1425.0,0.0>>

    • u1E912 (U+1E912): L<<645.0,1172.0>--<286.0,1171.0>>

    • 24 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-semi-vertical]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/adlamdisplay/ADLaMDisplay-Regular.ttf
Dehinted Size 70.3kb
Hinted Size 94.9kb
Increase 24.6kb
Change 35.0 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.000; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.28]"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/adlamdisplay [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 7 15 63 8 153 0
0% 3% 6% 26% 3% 62% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@aaronbell
Copy link
Collaborator Author

Generally I think this font is looking good, but there's a number of FAILS that I wanted to talk through.

🔥 FAIL: Check Google Fonts glyph coverage.

  • The font is intended primarily for ADLaM language support and therefore does not contain the full GF-latin-core set.

🔥 FAIL: Check license file has good copyright string.
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb
🔥 FAIL: Copyright notices match canonical pattern in fonts

  • I've followed Microsoft's preferred copyright string here. Let me know if you are concerned about this.

🔥 FAIL "ADLaM Display" contains an abbreviation.

  • FAIL is not accurate as this is the language name.

🔥 FAIL: Ensure dotted circle glyph is present and can attach marks.

  • AFAIK ADLaM does not require a complex shaper.

@github-actions
Copy link

Fontbakery report

Fontbakery version: 0.8.13

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[29] ADLaMDisplay-Regular.ttf
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
  • 🔥 FAIL Missing required codepoints:

    • 0x0102 (LATIN CAPITAL LETTER A WITH BREVE)

    • 0x0100 (LATIN CAPITAL LETTER A WITH MACRON)

    • 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)

    • 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)

    • 0x010C (LATIN CAPITAL LETTER C WITH CARON)

    • 0x010A (LATIN CAPITAL LETTER C WITH DOT ABOVE)

    • 0x010E (LATIN CAPITAL LETTER D WITH CARON)

    • 0x0110 (LATIN CAPITAL LETTER D WITH STROKE)

    • 0x011A (LATIN CAPITAL LETTER E WITH CARON)

    • 0x0116 (LATIN CAPITAL LETTER E WITH DOT ABOVE)

    • 96 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)
  • 🔥 FAIL First line in license file is:

"copyright (c) 2022 by microsoft. all rights reserved."

which does not match the expected format, similar to:

"Copyright 2022 The Familyname Project Authors (git url)" [code: bad-format]

🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)
  • 🔥 FAIL METADATA.pb: Copyright notices should match a pattern similar to:
    "Copyright 2020 The Familyname Project Authors (git url)"
    But instead we have got:
    "copyright (c) 2022 by microsoft. all rights reserved." [code: bad-notice-format]
🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)
  • 🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: "Copyright 2019 The Familyname Project Authors (git url)"
    But instead we have got:
    "Copyright (c) 2022 by Microsoft. All rights reserved." [code: bad-notice-format]
🔥 FAIL: Check family name for GF Guide compliance. (com.google.fonts/check/name/family_name_compliance)
  • 🔥 FAIL "ADLaM Display" contains an abbreviation. [code: abbreviation]
🔥 FAIL: Checking with fontTools.ttx (com.google.fonts/check/ttx_roundtrip)
  • 🔥 FAIL name id 256 missing from name table
  • INFO While converting TTF into an XML file, ttx emited the messages listed below.
🔥 FAIL: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • 🔥 FAIL No dotted circle glyph presentand font uses a complex shaper [code: missing-dotted-circle-complex]
WARN: URLs on DESCRIPTION file must not display http(s) prefix. (com.google.fonts/check/description/urls)
WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
  • WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: canadian-aboriginal, tifinagh, yi

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: math, tifinagh, coptic, cherokee

  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic

  • U+0307 COMBINING DOT ABOVE: try adding one of: tifinagh, syriac, math, old-permic, malayalam, canadian-aboriginal, tai-le, coptic

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage

  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
    13 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu [code: unreachable-subsetting]

WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + i

    • i + l [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • WARN It seems that Mark Jamra is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
  • WARN It seems that Neil Patel is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
  • WARN It seems that Andrew Footit is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • NULL
      [code: unreachable-glyphs]
WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: V	Contours detected: 3	Expected: 1

- Glyph name: W	Contours detected: 3	Expected: 1 or 2

- Glyph name: v	Contours detected: 3	Expected: 1

- Glyph name: w	Contours detected: 3	Expected: 1

- Glyph name: y	Contours detected: 3	Expected: 1

- Glyph name: uni00AD	Contours detected: 1	Expected: 0

- Glyph name: yacute	Contours detected: 4	Expected: 2

- Glyph name: ydieresis	Contours detected: 5	Expected: 3

- Glyph name: V	Contours detected: 3	Expected: 1

- Glyph name: W	Contours detected: 3	Expected: 1 or 2 

- 6 more.

Use -F or --full-lists to disable shortening of long lists.
[code: contour-count]

WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
  • WARN This font has a 'Soft Hyphen' character. [code: softhyphen]
WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 1434 among a set of 6 math glyphs.
    The following math glyphs have a different width, though:

Width = 1414:
less, greater

Width = 1430:
plusminus

Width = 1442:
multiply

Width = 1566:
approxequal

Width = 1432:
greaterequal, lessequal
[code: width-outliers]

WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
  • WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:

    • dollar (U+0024): X=515.0,Y=1.0 (should be at baseline 0?)

    • dollar (U+0024): X=661.0,Y=1432.0 (should be at cap-height 1434?)

    • percent (U+0025): X=564.0,Y=-1.0 (should be at baseline 0?)

    • colon (U+003A): X=289.0,Y=-1.0 (should be at baseline 0?)

    • C (U+0043): X=967.5,Y=-2.0 (should be at baseline 0?)

    • G (U+0047): X=1067.0,Y=-1.0 (should be at baseline 0?)

    • S (U+0053): X=337.5,Y=-1.0 (should be at baseline 0?)

    • c (U+0063): X=841.0,Y=-1.0 (should be at baseline 0?)

    • d (U+0064): X=665.5,Y=-2.0 (should be at baseline 0?)

    • ordfeminine (U+00AA): X=250.5,Y=1432.0 (should be at cap-height 1434?)

    • 30 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
  • WARN The following glyphs have colinear vectors:

    • V (U+0056): L<<1348.0,1274.0>--<1348.0,1275.0>> -> L<<1348.0,1275.0>--<1348.0,1277.0>>

    • V (U+0056): L<<60.0,1278.0>--<60.0,1277.0>> -> L<<60.0,1277.0>--<60.0,1274.0>>

    • W (U+0057): L<<60.0,1281.0>--<60.0,1280.0>> -> L<<60.0,1280.0>--<60.0,1277.0>>

    • fraction (U+2044): L<<-115.0,148.0>--<650.0,1383.0>> -> L<<650.0,1383.0>--<675.0,1423.0>>

    • fraction (U+2044): L<<-140.0,108.0>--<-115.0,148.0>> -> L<<-115.0,148.0>--<650.0,1383.0>>

    • fraction (U+2044): L<<827.0,1273.0>--<60.0,39.0>> -> L<<60.0,39.0>--<35.0,-1.0>>

    • fraction (U+2044): L<<852.0,1313.0>--<827.0,1273.0>> -> L<<827.0,1273.0>--<60.0,39.0>>

    • onehalf (U+00BD): L<<1528.0,1273.0>--<761.0,39.0>> -> L<<761.0,39.0>--<736.0,-1.0>>

    • onehalf (U+00BD): L<<1553.0,1313.0>--<1528.0,1273.0>> -> L<<1528.0,1273.0>--<761.0,39.0>>

    • onehalf (U+00BD): L<<561.0,108.0>--<586.0,148.0>> -> L<<586.0,148.0>--<1351.0,1383.0>>

    • 20 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-colinear-vectors]

WARN: Do outlines contain any semi-vertical or semi-horizontal lines? (com.google.fonts/check/outline_semi_vertical)
  • WARN The following glyphs have semi-vertical/semi-horizontal lines:

    • L (U+004C): L<<597.0,262.0>--<904.0,263.0>>

    • Z (U+005A): L<<482.0,262.0>--<1107.0,263.0>>

    • Zcaron (U+017D): L<<482.0,262.0>--<1107.0,263.0>>

    • u (U+0075): L<<136.0,406.0>--<135.0,914.0>>

    • u1E901 (U+1E901): L<<131.0,964.0>--<130.0,1274.0>>

    • u1E901 (U+1E901): L<<453.0,1274.0>--<454.0,1056.0>>

    • u1E903 (U+1E903): L<<893.0,855.0>--<892.0,1049.0>>

    • u1E905 (U+1E905): L<<1384.0,424.0>--<1387.0,1037.0>>

    • u1E911 (U+1E911): L<<1426.0,1166.0>--<1425.0,0.0>>

    • u1E912 (U+1E912): L<<645.0,1172.0>--<286.0,1171.0>>

    • 24 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-semi-vertical]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/adlamdisplay/ADLaMDisplay-Regular.ttf
Dehinted Size 70.3kb
Hinted Size 94.9kb
Increase 24.6kb
Change 35.0 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.000; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.28]"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/adlamdisplay [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 7 15 63 8 153 0
0% 3% 6% 26% 3% 62% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@aaronbell aaronbell linked an issue Jul 13, 2023 that may be closed by this pull request
9 tasks
@RosaWagner
Copy link
Contributor

🔥 FAIL "ADLaM Display" contains an abbreviation.
FAIL is not accurate as this is the language name.

You can add that to the exception list in fontbakery so it doesn't fail anymore: https://github.com/googlefonts/fontbakery/tree/main/Lib/fontbakery/data/googlefonts

I'll ask about the copyright notice in a meeting ;)

@chrissimpkins
Copy link
Collaborator

The font is intended primarily for ADLaM language support and therefore does not contain the full GF-latin-core set.

Latin kernel is sufficient here.

Check license file has good copyright string

We discussed in our pipeline meeting and this exception is approved in both the font file and the metadata configuration file.

@github-actions
Copy link

Fontbakery report

Fontbakery version: 0.8.13

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[29] ADLaMDisplay-Regular.ttf
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
  • 🔥 FAIL Missing required codepoints:

    • 0x0102 (LATIN CAPITAL LETTER A WITH BREVE)

    • 0x0100 (LATIN CAPITAL LETTER A WITH MACRON)

    • 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)

    • 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)

    • 0x010C (LATIN CAPITAL LETTER C WITH CARON)

    • 0x010A (LATIN CAPITAL LETTER C WITH DOT ABOVE)

    • 0x010E (LATIN CAPITAL LETTER D WITH CARON)

    • 0x0110 (LATIN CAPITAL LETTER D WITH STROKE)

    • 0x011A (LATIN CAPITAL LETTER E WITH CARON)

    • 0x0116 (LATIN CAPITAL LETTER E WITH DOT ABOVE)

    • 96 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)
  • 🔥 FAIL First line in license file is:

"copyright (c) 2022 by microsoft. all rights reserved."

which does not match the expected format, similar to:

"Copyright 2022 The Familyname Project Authors (git url)" [code: bad-format]

🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)
  • 🔥 FAIL METADATA.pb: Copyright notices should match a pattern similar to:
    "Copyright 2020 The Familyname Project Authors (git url)"
    But instead we have got:
    "copyright (c) 2022 by microsoft. all rights reserved." [code: bad-notice-format]
🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)
  • 🔥 FAIL Name Table entry: Copyright notices should match a pattern similar to: "Copyright 2019 The Familyname Project Authors (git url)"
    But instead we have got:
    "Copyright (c) 2022 by Microsoft. All rights reserved." [code: bad-notice-format]
🔥 FAIL: Check family name for GF Guide compliance. (com.google.fonts/check/name/family_name_compliance)
  • 🔥 FAIL "ADLaM Display" contains an abbreviation. [code: abbreviation]
🔥 FAIL: Checking with fontTools.ttx (com.google.fonts/check/ttx_roundtrip)
  • 🔥 FAIL name id 256 missing from name table
  • INFO While converting TTF into an XML file, ttx emited the messages listed below.
🔥 FAIL: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • 🔥 FAIL No dotted circle glyph presentand font uses a complex shaper [code: missing-dotted-circle-complex]
WARN: URLs on DESCRIPTION file must not display http(s) prefix. (com.google.fonts/check/description/urls)
WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
  • WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: yi, tifinagh, canadian-aboriginal

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, math, tifinagh, cherokee

  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh

  • U+0307 COMBINING DOT ABOVE: try adding one of: math, old-permic, tifinagh, coptic, tai-le, malayalam, syriac, canadian-aboriginal

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee

  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le
    6 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: adlam, latin, latin-ext, menu [code: unreachable-subsetting]

WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + i

    • i + l [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • WARN It seems that Mark Jamra is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
  • WARN It seems that Neil Patel is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
  • WARN It seems that Andrew Footit is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • NULL
      [code: unreachable-glyphs]
WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: V	Contours detected: 3	Expected: 1

- Glyph name: W	Contours detected: 3	Expected: 1 or 2

- Glyph name: v	Contours detected: 3	Expected: 1

- Glyph name: w	Contours detected: 3	Expected: 1

- Glyph name: y	Contours detected: 3	Expected: 1

- Glyph name: uni00AD	Contours detected: 1	Expected: 0

- Glyph name: yacute	Contours detected: 4	Expected: 2

- Glyph name: ydieresis	Contours detected: 5	Expected: 3

- Glyph name: V	Contours detected: 3	Expected: 1

- Glyph name: W	Contours detected: 3	Expected: 1 or 2 

- 6 more.

Use -F or --full-lists to disable shortening of long lists.
[code: contour-count]

WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
  • WARN This font has a 'Soft Hyphen' character. [code: softhyphen]
WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 1434 among a set of 6 math glyphs.
    The following math glyphs have a different width, though:

Width = 1414:
greater, less

Width = 1430:
plusminus

Width = 1442:
multiply

Width = 1566:
approxequal

Width = 1432:
lessequal, greaterequal
[code: width-outliers]

WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
  • WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:

    • dollar (U+0024): X=515.0,Y=1.0 (should be at baseline 0?)

    • dollar (U+0024): X=661.0,Y=1432.0 (should be at cap-height 1434?)

    • percent (U+0025): X=564.0,Y=-1.0 (should be at baseline 0?)

    • colon (U+003A): X=289.0,Y=-1.0 (should be at baseline 0?)

    • C (U+0043): X=967.5,Y=-2.0 (should be at baseline 0?)

    • G (U+0047): X=1067.0,Y=-1.0 (should be at baseline 0?)

    • S (U+0053): X=337.5,Y=-1.0 (should be at baseline 0?)

    • c (U+0063): X=841.0,Y=-1.0 (should be at baseline 0?)

    • d (U+0064): X=665.5,Y=-2.0 (should be at baseline 0?)

    • ordfeminine (U+00AA): X=250.5,Y=1432.0 (should be at cap-height 1434?)

    • 30 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
  • WARN The following glyphs have colinear vectors:

    • V (U+0056): L<<1348.0,1274.0>--<1348.0,1275.0>> -> L<<1348.0,1275.0>--<1348.0,1277.0>>

    • V (U+0056): L<<60.0,1278.0>--<60.0,1277.0>> -> L<<60.0,1277.0>--<60.0,1274.0>>

    • W (U+0057): L<<60.0,1281.0>--<60.0,1280.0>> -> L<<60.0,1280.0>--<60.0,1277.0>>

    • fraction (U+2044): L<<-115.0,148.0>--<650.0,1383.0>> -> L<<650.0,1383.0>--<675.0,1423.0>>

    • fraction (U+2044): L<<-140.0,108.0>--<-115.0,148.0>> -> L<<-115.0,148.0>--<650.0,1383.0>>

    • fraction (U+2044): L<<827.0,1273.0>--<60.0,39.0>> -> L<<60.0,39.0>--<35.0,-1.0>>

    • fraction (U+2044): L<<852.0,1313.0>--<827.0,1273.0>> -> L<<827.0,1273.0>--<60.0,39.0>>

    • onehalf (U+00BD): L<<1528.0,1273.0>--<761.0,39.0>> -> L<<761.0,39.0>--<736.0,-1.0>>

    • onehalf (U+00BD): L<<1553.0,1313.0>--<1528.0,1273.0>> -> L<<1528.0,1273.0>--<761.0,39.0>>

    • onehalf (U+00BD): L<<561.0,108.0>--<586.0,148.0>> -> L<<586.0,148.0>--<1351.0,1383.0>>

    • 20 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-colinear-vectors]

WARN: Do outlines contain any semi-vertical or semi-horizontal lines? (com.google.fonts/check/outline_semi_vertical)
  • WARN The following glyphs have semi-vertical/semi-horizontal lines:

    • L (U+004C): L<<597.0,262.0>--<904.0,263.0>>

    • Z (U+005A): L<<482.0,262.0>--<1107.0,263.0>>

    • Zcaron (U+017D): L<<482.0,262.0>--<1107.0,263.0>>

    • u (U+0075): L<<136.0,406.0>--<135.0,914.0>>

    • u1E901 (U+1E901): L<<131.0,964.0>--<130.0,1274.0>>

    • u1E901 (U+1E901): L<<453.0,1274.0>--<454.0,1056.0>>

    • u1E903 (U+1E903): L<<893.0,855.0>--<892.0,1049.0>>

    • u1E905 (U+1E905): L<<1384.0,424.0>--<1387.0,1037.0>>

    • u1E911 (U+1E911): L<<1426.0,1166.0>--<1425.0,0.0>>

    • u1E912 (U+1E912): L<<645.0,1172.0>--<286.0,1171.0>>

    • 24 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-semi-vertical]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/adlamdisplay/ADLaMDisplay-Regular.ttf
Dehinted Size 70.3kb
Hinted Size 94.9kb
Increase 24.6kb
Change 35.0 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.000; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.28]"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/adlamdisplay [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 7 15 63 8 153 0
0% 3% 6% 26% 3% 62% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner RosaWagner merged commit 96b2d25 into main Jul 21, 2023
7 checks passed
@RosaWagner RosaWagner deleted the gftools_packager_ofl_adlamdisplay branch July 21, 2023 10:54
@eliheuer
Copy link
Collaborator

eliheuer commented Aug 17, 2023

@aaronbell @RosaWagner https://googlefonts.github.io/gf-guide/onboarding.html says "no references to languages or writing systems" was there an exception made for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Add ADLaM Display
4 participants