-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edu VIC WA NT Pre Guide: Version 1.000 added #7456
Conversation
Taken from the upstream repo https://github.com/SorkinType/VICWANTSchoolHandAustralia at commit SorkinType/VICWANTSchoolhandAustralia@abab94d.
This comment was marked as outdated.
This comment was marked as outdated.
This Fail can be ignored since this is the guide variant, so the space is also expected to have outlines. |
FontBakery reportfontbakery version: 0.12.0a6 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] EduVICWANTPreGuide[wght].ttfAll other checks[19] EduVICWANTPreGuide[wght].ttf
|
ofl/eduvicwantpreguide/EduVICWANTPreGuide[wght].ttf | |
---|---|
Dehinted Size | 1.2Mb |
Hinted Size | 1.2Mb |
Increase | 24 bytes |
Change | 0.0 % |
[code: size-impact] |
⚠️ **WARN** Is there kerning info for non-ligated sequences?
-
⚠️ WARN GPOS table lacks kerning info for the following non-ligated sequences:-
f + glyph00274
-
glyph00274 + glyph00289 [code: lacks-kern-info]
-
⚠️ **WARN** Are there caret positions declared for every ligature?
⚠️ WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]
⚠️ **WARN** Ensure fonts have ScriptLangTags declared on the 'meta' table.
⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
[1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 1 | 11 | 44 | 10 | 183 | 0 |
0% | 0% | 0% | 4% | 18% | 4% | 73% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
The Top Guide position was confirmed to be ok here |
Do not push; in fact, we will revert. We went too fast here, and need to make the naming consistent ("Guides"). |
Taken from the upstream repo https://github.com/SorkinType/VICWANTSchoolHandAustralia at commit SorkinType/VICWANTSchoolhandAustralia@abab94d.
PR Checklist:
- [ ] Minisite_url definition in the METADATA.pb file for commissioned projects- [ ] Primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target