Briem Hand: Version 1.004 added #7652
Conversation
* Briem Hand Version 1.002 taken from the upstream repo https://github.com/SorkinType/Briem-Hand.git at commit https://github.com/SorkinType/Briem-Hand/commit/.
simoncozens
force-pushed
the
gftools_packager_ofl_briemhand
branch
from
a03fbd9
to
099159d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
|
FontBakery reportfontbakery version: 0.12.5 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [3] BriemHand[wght].ttf💥 ERROR Check tabular widths don't have kerning.
[code: failed-check] All other checks[18] BriemHand[wght].ttf🔥 FAIL Ensure the font supports case swapping for all its glyphs.
🔥 FAIL Ensure dotted circle glyph is present and can attach marks.
[code: unattached-dotted-circle-marks] 🔥 FAIL Shapes languages in all GF glyphsets.
|
| 💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
|---|---|---|---|---|---|---|---|
| 1 | 0 | 3 | 9 | 42 | 9 | 186 | 0 |
| 0% | 0% | 1% | 4% | 17% | 4% | 74% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
FontBakery reportfontbakery version: 0.12.6 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [3] BriemHand[wght].ttf💥 ERROR Check tabular widths don't have kerning.
[code: failed-check] All other checks[18] BriemHand[wght].ttf🔥 FAIL Ensure the font supports case swapping for all its glyphs.
🔥 FAIL Shapes languages in all GF glyphsets.
|
| 💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
|---|---|---|---|---|---|---|---|
| 1 | 0 | 2 | 9 | 42 | 10 | 187 | 0 |
| 0% | 0% | 1% | 4% | 17% | 4% | 75% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
|
lgtm! except this one: 
|
|
@simoncozens I don't understand where the warn is coming from, because we use the right name in the catalogue: https://fonts.google.com/specimen/Briem+Hand/about?query=Gunnlaugur+SE+Briem I remember I added the 'SE' in the PR: #7475 |
|
Fontbakery bug, we check for the designer being in the catalogue by normalizing the designer's name ("Gunnlaugur SE Briem" -> "gunnlaugursebriem") and then looking for that directory in the repository ( This normally works, but in this case we don't have that directory - it is called |
|
This one's also pretty bad... Fix coming... |
|
Ah I saw that, but I think the update is the good design. to confirm! |
FontBakery reportfontbakery version: 0.12.6 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [3] BriemHand[wght].ttf💥 ERROR Check tabular widths don't have kerning.
[code: failed-check] All other checks[18] BriemHand[wght].ttf🔥 FAIL Ensure the font supports case swapping for all its glyphs.
🔥 FAIL Shapes languages in all GF glyphsets.
|
| 💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
|---|---|---|---|---|---|---|---|
| 1 | 0 | 2 | 9 | 42 | 10 | 187 | 0 |
| 0% | 0% | 1% | 4% | 17% | 4% | 75% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
|
Status: We don't merge that PR, until we have the confirmation and the review of the designer. |
This may be too conservative, we can merge the PR and get to sandbox, but we should wait for designer approval before going to prod :) |
FontBakery reportfontbakery version: 0.12.6 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [3] BriemHand[wght].ttf💥 ERROR Check tabular widths don't have kerning.
[code: failed-check] All other checks[18] BriemHand[wght].ttf🔥 FAIL Ensure the font supports case swapping for all its glyphs.
🔥 FAIL Shapes languages in all GF glyphsets.
|
| 💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
|---|---|---|---|---|---|---|---|
| 1 | 0 | 2 | 9 | 43 | 10 | 186 | 0 |
| 0% | 0% | 1% | 4% | 17% | 4% | 74% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
|
Thanks @emmamarichal :) Good to get this refreshed on sandbox! But should be blocked from prod until Briem gives final approval |
|
@davelab6 @simoncozens I don't recall, do we have any update from Briem about this? |
|
We have had some Glyphs file updates from Briem but I have not looked at them yet. |
emmamarichal
changed the title
Taken from the upstream repo https://github.com/SorkinType/Briem-Hand at commit SorkinType/Briem-Hand@68fedd7.
PR Checklist: