Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noto Serif Devanagari: Version 2.006 added #7693

Merged
merged 1 commit into from
May 24, 2024

Conversation

simoncozens
Copy link
Collaborator

@simoncozens simoncozens commented May 16, 2024

Taken from the upstream repo https://github.com/notofonts/devanagari at commit notofonts/devanagari@edcf14f.

PR Checklist:

  • Family categorization tags collected from the type design team with the Categories Form
  • Minisite_url definition in the METADATA.pb file for commissioned projects
  • Primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

This comment was marked as outdated.

@simoncozens
Copy link
Collaborator Author

This release:

* Adds a number of new Unicode characters
* Cleans up the OpenType code
* Encodes a number of vedic signs (#39)
* Removes the semibold master
* Fixes a bug in kerning between z-dda
* Fixes a number of fontbakery fails
* Improves support for the Santali language (#36)
* Fixes a clash between nukta and lower vowel signs (#35)

Copy link
Collaborator

@m4rc1e m4rc1e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm loving a lot of the new conjuncts!

These sequences need some work:

उन्होेंने

Screenshot 2024-05-17 at 11 03 40

औैर

Screenshot 2024-05-17 at 11 04 08

कु्छ

Screenshot 2024-05-17 at 11 04 25

ईेडी

Screenshot 2024-05-17 at 11 05 13

@simoncozens
Copy link
Collaborator Author

Updated

@simoncozens simoncozens force-pushed the gftools_packager_ofl_notoserifdevanagari branch from 160f3a2 to 6425735 Compare May 20, 2024 11:59
Copy link

FontBakery report

fontbakery version: 0.12.6

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] NotoSerifDevanagari[wdth,wght].ttf
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]

All other checks

[13] NotoSerifDevanagari[wdth,wght].ttf
⚠️ WARN Check mark characters are in GDEF mark glyph class.
  • ⚠️ WARN

    The following mark characters could be in the GDEF mark glyph class:
    uni1CE0 (U+1CE0), uni1CE2 (U+1CE2), uni1CE3 (U+1CE3), uni1CE4 (U+1CE4), uni1CE5 (U+1CE5), uni1CE6 (U+1CE6), uni1CE7 (U+1CE7) and uni1CE8 (U+1CE8)


    [code: mark-chars]
⚠️ WARN Detect any interpolation issues in the font.
  • ⚠️ WARN

    Interpolation issues were found in the font:

- Contour order differs in glyph 'zhdeva': [0, 1, 2, 3, 4] in wght=900,wdth=100, [0, 1, 3, 4, 2] in wght=100,wdth=62.

- Contour order differs in glyph 'zhdeva': [0, 1, 2, 3, 4] in wght=100,wdth=62, [0, 1, 4, 2, 3] in wght=900,wdth=62.

- Contour 0 point 48 in glyph 'two' has a kink between location wght=900,wdth=100 and location wght=100,wdth=62

[code: interpolation-issues]

⚠️ WARN Does the font contain a soft hyphen?
  • ⚠️ WARN

    This font has a 'Soft Hyphen' character.


    [code: softhyphen]
⚠️ WARN Check font contains no unreachable glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- awMatra_rephCandrabindudeva

- awMatra_rephanusvaradeva

- ayMatra_rephCandrabindudeva

- ayMatra_rephanusvaradeva

- eCandraMatra_candrabindudeva

- ghh_nukadeva

- oeMatra_candrabindudeva

- oeMatra_rephanusvaradeva

- oeMatra_rephcandrabindudeva

- two_karshana

- 179 more.

Use -F or --full-lists to disable shortening of long lists.

[code: unreachable-glyphs]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į⃰ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦⃰ į̧̀ į̧́

Your font fully covers the following languages that require the soft-dotted feature: Navajo (Latn, 166,319 speakers), Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Lugbara (Latn, 2,200,000 speakers), Mfumte (Latn, 79,000 speakers), Cicipu (Latn, 44,000 speakers), Mango (Latn, 77,000 speakers), Makaa (Latn, 221,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Southern Kisi (Latn, 360,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Igbo (Latn, 27,823,640 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Mundani (Latn, 34,000 speakers), Zapotec (Latn, 490,000 speakers), Dii (Latn, 71,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Ejagham (Latn, 120,000 speakers), Sar (Latn, 500,000 speakers), South Central Banda (Latn, 244,000 speakers), Nateni (Latn, 100,000 speakers), Gulay (Latn, 250,478 speakers), Basaa (Latn, 332,940 speakers), Kom (Latn, 360,685 speakers), Nzakara (Latn, 50,000 speakers), Avokaya (Latn, 100,000 speakers), Vute (Latn, 21,000 speakers), Ebira (Latn, 2,200,000 speakers), Dan (Latn, 1,099,244 speakers), Ekpeye (Latn, 226,000 speakers), Aghem (Latn, 38,843 speakers), Belarusian (Cyrl, 10,064,517 speakers), Koonzime (Latn, 40,000 speakers), Fur (Latn, 1,230,163 speakers), Ma’di (Latn, 584,000 speakers), Yala (Latn, 200,000 speakers), Bafut (Latn, 158,146 speakers).

[code: soft-dotted]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: canadian-aboriginal, tifinagh, yi
  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition
  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: math, tifinagh, cherokee, coptic
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: canadian-aboriginal, syriac, math, coptic, malayalam, tifinagh, old-permic, tai-le
  • U+030A COMBINING RING ABOVE: try adding syriac 6 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: devanagari, latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/notoserifdevanagari


    [code: family-path]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/notoserifdevanagari/NotoSerifDevanagari[wdth,wght].ttf
Dehinted Size 739.9kb
Hinted Size 739.9kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.006']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght-wdth', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 0 7 41 8 195 0
0% 0% 0% 3% 16% 3% 78% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@simoncozens
Copy link
Collaborator Author

उन्होेंने is a rubbish sequence, you can see from the dotted circles; I've fixed the others.

@vv-monsalve
Copy link
Collaborator

@simoncozens, the canges look good to me but I'm not an expert. Could you confirm the spotted here are the intended ones?
noto-deva-ba

@vv-monsalve vv-monsalve added the -- Needs confirmation from upstream or onboarder label May 23, 2024
@simoncozens
Copy link
Collaborator Author

Yes, these are all intended.

@vv-monsalve
Copy link
Collaborator

@m4rc1e, this seems solved now, but the merge is blocked per your request.
Would you like to unblock it?

@m4rc1e m4rc1e merged commit 084d8e4 into main May 24, 2024
7 checks passed
@m4rc1e m4rc1e deleted the gftools_packager_ofl_notoserifdevanagari branch May 24, 2024 14:14
@vv-monsalve vv-monsalve removed the -- Needs confirmation from upstream or onboarder label May 24, 2024
@vv-monsalve vv-monsalve changed the title Noto Serif Devanagari: Version 2.005 added Noto Serif Devanagari: Version 2.006 added May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

3 participants