-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOTFIX] Concert One v-metrics #7779
Conversation
FontBakery reportfontbakery version: 0.12.6 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] ConcertOne-Regular.ttfAll other checks[38] ConcertOne-Regular.ttf🔥 FAIL Ensure component transforms do not perform scaling or rotation.
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
🔥 FAIL METADATA.pb font.full_name and font.post_script_name fields have equivalent values ?
🔥 FAIL METADATA.pb subsets should be alphabetically ordered.
🔥 FAIL Copyright notices match canonical pattern in METADATA.pb
"Copyright 2020 The Familyname Project Authors (git url)" But instead we have got: "copyright (c) 2011, 2011 johan kallas ([email protected]), copyright (c) 2011, 2011 mihkel virkus ([email protected]), with reserved font name concert." [code: bad-notice-format]🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL Does DESCRIPTION file contain broken links?
🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL?
🔥 FAIL Name table strings must not contain the string 'Reserved Font Name'.
This is an error except in a few specific rare cases. [code: rfn]
This is an error except in a few specific rare cases. [code: rfn]🔥 FAIL Check license file has good copyright string.
"copyright (c) 2011 johan kallas ([email protected])," which does not match the expected format, similar to: "Copyright 2022 The Familyname Project Authors (git url)" [code: bad-format]🔥 FAIL Copyright notices match canonical pattern in fonts
"Copyright 2019 The Familyname Project Authors (git url)" But instead we have got: "Copyright (c) 2011, 2011 Johan Kallas ([email protected]), Copyright (c) 2011, 2011 Mihkel Virkus ([email protected]), with Reserved Font Name Concert." [code: bad-notice-format]
"Copyright 2019 The Familyname Project Authors (git url)" But instead we have got: "Copyright (c) 2011, 2011 Johan Kallas ([email protected]), Copyright (c) 2011, 2011 Mihkel Virkus ([email protected]), with Reserved Font Name Concert." [code: bad-notice-format]🔥 FAIL Check Google Fonts glyph coverage.
Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]🔥 FAIL Font enables smart dropout control in "prep" table instructions?
|
ofl/concertone/ConcertOne-Regular.ttf | |
---|---|
Dehinted Size | 43.4kb |
Hinted Size | 69.4kb |
Increase | 25.9kb |
Change | 59.7 % |
ℹ️ INFO Font has old ttfautohint applied?
- ℹ️ INFO
Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.004', 'Version 1.004']
[code: version-not-detected]
[2] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 14 | 18 | 67 | 10 | 142 | 0 |
0% | 0% | 6% | 7% | 27% | 4% | 57% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Following the linked issue, LGTM. |
See the discussion here: #362
OS/2 and hhea table fixed + version bumped