Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edu AU VIC WA NT Pre: Version 1.001 added #8022

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

simoncozens
Copy link
Collaborator

Taken from the upstream repo https://github.com/SorkinType/VICWANTSchoolHandAustralia at commit SorkinType/VICWANTSchoolhandAustralia@abab94d.

PR Checklist:

  • Family categorization tags collected from the type design team with the Categories Form
    - [ ] Minisite_url definition in the METADATA.pb file for commissioned projects
    - [ ] Primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

@simoncozens simoncozens mentioned this pull request Aug 13, 2024
9 tasks
@simoncozens simoncozens linked an issue Aug 13, 2024 that may be closed by this pull request
9 tasks
Copy link

FontBakery report

fontbakery version: 0.12.9

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] EduAUVICWANTPre[wght].ttf
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/eduauvicwantpre does not have an article.


    [code: lacks-article]

All other checks

[17] EduAUVICWANTPre[wght].ttf
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    GF_Latin_Core glyphset:

Language FAIL messages
lt_Latn (Lithuanian) Shaper didn't attach ogonekcomb to idotless.ss01
[code: failed-language-shaping]
⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 1017 among a set of 4 math glyphs.
    The following math glyphs have a different width, though:

Width = 961: less

Width = 962: greater

Width = 1042: plusminus

Width = 1011: multiply

Width = 1052: approxequal

Width = 1037: notequal

Width = 1039: greaterequal, lessequal

[code: width-outliers]
⚠️ WARN Font has **proper** whitespace glyph names?
  • ⚠️ WARN

    Glyph 0x00A0 is called "nbspace": Change to "uni00A0"


    [code: not-recommended-00a0]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: tifinagh, yi, canadian-aboriginal
  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, math, cherokee, tifinagh
  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
  • U+0307 COMBINING DOT ABOVE: try adding one of: tifinagh, tai-le, old-permic, syriac, malayalam, canadian-aboriginal, coptic, math
  • U+030A COMBINING RING ABOVE: try adding syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage 37 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Ensure files are not too large.
  • ⚠️ WARN

    Font file is 1.2Mb; ideally it should be less than 1.0Mb


    [code: large-font]
⚠️ WARN Is there kerning info for non-ligated sequences?
  • ⚠️ WARN

    GPOS table lacks kerning info for the following non-ligated sequences:

- f + i

- f + l

[code: lacks-kern-info]

⚠️ WARN Check font follows the Google Fonts vertical metric schema
  • ⚠️ WARN

    We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.7395x (3479)


    [code: bad-hhea-range]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/eduauvicwantpre


    [code: family-path]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

- vhea

- vmtx

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/eduauvicwantpre/EduAUVICWANTPre[wght].ttf
Dehinted Size 1.2Mb
Hinted Size 1.2Mb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ℹ️ INFO

    Latn


    [code: dlng-tag]

  • ℹ️ INFO

    Latn


    [code: slng-tag]

ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.001']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 1 7 44 11 189 0
0% 0% 0% 3% 17% 4% 75% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@vv-monsalve
Copy link
Collaborator

vv-monsalve commented Aug 16, 2024

  • Similar comment about the name schema: the family name should include AU particle.
  • @EbenSorkin same quotes situation as in the Cursive variant
    Screenshot 2024-08-16 at 17 43 36

@vv-monsalve vv-monsalve added the -- Needs Upstream Resolution Upstream fix required before moving forward label Aug 16, 2024
@simoncozens
Copy link
Collaborator Author

PR name is wrong, but font name is correct.

@simoncozens simoncozens changed the title Edu VIC WA NT Pre: Version 1.001 added Edu AU VIC WA NT Pre: Version 1.001 added Aug 18, 2024
@emmamarichal
Copy link
Collaborator

@EbenSorkin, have you seen this? :)

same quotes situation as in the Cursive variant

@simoncozens
Copy link
Collaborator Author

Maybe it's fixed now, let me take a look

@emmamarichal
Copy link
Collaborator

Is the CI still broken @simoncozens? The checks failed again 🤔

@simoncozens
Copy link
Collaborator Author

No, but rerunning the job runs it with the original Action, not the updated one. We need to add a new commit to start a new Action.

@simoncozens simoncozens force-pushed the gftools_packager_ofl_eduauvicwantpre branch from 1b13e15 to 87425fd Compare September 12, 2024 13:42
Copy link

FontBakery report

fontbakery version: 0.12.10

Check results

[18] EduAUVICWANTPre[wght].ttf
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    GF_Latin_Core glyphset:

Language FAIL messages
lt_Latn (Lithuanian) Shaper didn't attach ogonekcomb to idotless.ss01
[code: failed-language-shaping]
⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 1017 among a set of 4 math glyphs.
    The following math glyphs have a different width, though:

Width = 961: less

Width = 962: greater

Width = 1042: plusminus

Width = 1011: multiply

Width = 1052: approxequal

Width = 1037: notequal

Width = 1039: greaterequal, lessequal

[code: width-outliers]
⚠️ WARN Font has **proper** whitespace glyph names?
  • ⚠️ WARN

    Glyph 0x00A0 is called "nbspace": Change to "uni00A0"


    [code: not-recommended-00a0]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/eduauvicwantpre does not have an article.


    [code: lacks-article]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: tifinagh, canadian-aboriginal, yi
  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, math, cherokee, coptic
  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
  • U+0307 COMBINING DOT ABOVE: try adding one of: malayalam, math, tifinagh, canadian-aboriginal, old-permic, tai-le, syriac, coptic
  • U+030A COMBINING RING ABOVE: try adding syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee 37 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Ensure files are not too large.
  • ⚠️ WARN

    Font file is 1.2Mb; ideally it should be less than 1.0Mb


    [code: large-font]
⚠️ WARN Is there kerning info for non-ligated sequences?
  • ⚠️ WARN

    GPOS table lacks kerning info for the following non-ligated sequences:

- f + i

- f + l

[code: lacks-kern-info]

⚠️ WARN Check font follows the Google Fonts vertical metric schema
  • ⚠️ WARN

    We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.7395x (3479)


    [code: bad-hhea-range]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/eduauvicwantpre


    [code: family-path]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

- vhea

- vmtx

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/eduauvicwantpre/EduAUVICWANTPre[wght].ttf
Dehinted Size 1.2Mb
Hinted Size 1.2Mb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ℹ️ INFO

    Latn


    [code: dlng-tag]

  • ℹ️ INFO

    Latn


    [code: slng-tag]

ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.001']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 1 7 44 11 188 0
0% 0% 0% 3% 18% 4% 75% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@emmamarichal
Copy link
Collaborator

@simoncozens @EbenSorkin

Fontbakery

This warns appeared in the last version:

⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
Family metadata at ofl/eduauvicwantpre does not have an article.

I just check if it's intentional?

Outlines / Anchors

- Ogoneks to check
Screenshot 2024-09-13 at 15 20 14
Screenshot 2024-09-13 at 15 20 41
Screenshot 2024-09-13 at 15 21 19
Screenshot 2024-09-13 at 15 23 15

- Regarding quotes and #8022 (comment), is this result ok?

Screenshot 2024-09-13 at 15 19 02

- caron.alt position looks wrong

Screenshot 2024-09-13 at 15 23 35 Screenshot 2024-09-13 at 15 26 10

- check this
Screenshot 2024-09-13 at 15 20 28

@simoncozens simoncozens force-pushed the gftools_packager_ofl_eduauvicwantpre branch from 87425fd to 8f0e4df Compare September 27, 2024 07:27
@simoncozens simoncozens removed the -- Needs Upstream Resolution Upstream fix required before moving forward label Sep 27, 2024
@simoncozens
Copy link
Collaborator Author

I fixed the anchors on these glyphs.

Copy link

FontBakery report

fontbakery version: 0.13.0a1

Check results

[18] EduAUVICWANTPre[wght].ttf
⚠️ WARN Ensure files are not too large.
  • ⚠️ WARN

    Font file is 1.2Mb; ideally it should be less than 1.0Mb


    [code: large-font]
⚠️ WARN Is there kerning info for non-ligated sequences?
  • ⚠️ WARN

    GPOS table lacks kerning info for the following non-ligated sequences:

- f + i

- f + l

[code: lacks-kern-info]

⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 1017 among a set of 4 math glyphs.
    The following math glyphs have a different width, though:

Width = 961: less

Width = 962: greater

Width = 1042: plusminus

Width = 1011: multiply

Width = 1052: approxequal

Width = 1037: notequal

Width = 1039: lessequal, greaterequal

[code: width-outliers]
⚠️ WARN Font has **proper** whitespace glyph names?
  • ⚠️ WARN

    Glyph 0x00A0 is called "nbspace": Change to "uni00A0"


    [code: not-recommended-00a0]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/eduauvicwantpre does not have an article.


    [code: lacks-article]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, math, coptic, tifinagh
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: coptic, old-permic, todhri, malayalam, duployan, tai-le, tifinagh, math, canadian-aboriginal, hebrew, syriac
  • U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le
  • U+0312 COMBINING TURNED COMMA ABOVE: try adding math 35 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Shapes languages in all GF glyphsets.
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: Ŀ, ŀ ca_Latn (Catalan)
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: Ŧ, ŧ, Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ fi_Latn (Finnish)
Some auxiliary glyphs were missing: Ŧ, ŧ nb_Latn (Norwegian Bokmål)
[code: warning-language-shaping]
⚠️ WARN Check font follows the Google Fonts vertical metric schema
  • ⚠️ WARN

    We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.7395x (3479)


    [code: bad-hhea-range]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/eduauvicwantpre


    [code: family-path]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/eduauvicwantpre/EduAUVICWANTPre[wght].ttf
Dehinted Size 1.2Mb
Hinted Size 1.2Mb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

- vhea

- vmtx

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ℹ️ INFO

    Latn


    [code: dlng-tag]

  • ℹ️ INFO

    Latn


    [code: slng-tag]

ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.001']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 0 8 45 11 189 0
0% 0% 0% 3% 18% 4% 75% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@emmamarichal emmamarichal merged commit b2bfddd into main Oct 2, 2024
5 of 9 checks passed
@emmamarichal emmamarichal deleted the gftools_packager_ofl_eduauvicwantpre branch October 2, 2024 12:44
@emmamarichal emmamarichal removed a link to an issue Oct 11, 2024
9 tasks
@emmamarichal emmamarichal linked an issue Oct 11, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Dev / PR Merged
Development

Successfully merging this pull request may close these issues.

Add Edu VIC WA NT Pre
3 participants