Use file offsets in traces if object has no symbols #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable! Is there any reason someone want to turn off this feature? I'm not sure if we need |
I agree it's probably unnecessary; removed. Only added that in case someone is depending on the return value for something as we're unlikely to ever return "false" after this change. Personally I think |
Fallback to using file offsets if no symbol is found, like we do if the object could not be opened. This makes backtraces usable even if objects in the trace are stripped, since the trace can be symbolized by post-processing it with a tool like asan_symbolize.py. Note that this is not currently compatible with SymbolizeCallback as this overwrites the filename in the buffer. The behavior is unchanged in that case. Closes: #514
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use file offsets in traces if object has no symbols
Fallback to using file offsets if no symbol is found, like we do if the
object could not be opened.
This makes backtraces usable even if objects in the trace are stripped,
since the trace can be symbolized by post-processing it with a tool like
asan_symbolize.py.
Note that this is not currently compatible with SymbolizeCallback as
this overwrites the filename in the buffer. The behavior is unchanged
in that case.
Closes: #514