Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide backward compatible send overload #763

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Dec 14, 2021

@sergiud sergiud added the bug label Dec 14, 2021
@sergiud sergiud added this to the 0.6 milestone Dec 14, 2021
@sergiud sergiud requested a review from drigz December 14, 2021 20:38
@codecov-commenter
Copy link

Codecov Report

Merging #763 (4765234) into master (d09b999) will decrease coverage by 0.24%.
The diff coverage is 58.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #763      +/-   ##
==========================================
- Coverage   73.01%   72.77%   -0.25%     
==========================================
  Files          17       17              
  Lines        3217     3232      +15     
==========================================
+ Hits         2349     2352       +3     
- Misses        868      880      +12     
Impacted Files Coverage Δ
src/utilities.h 100.00% <ø> (ø)
src/glog/logging.h.in 80.00% <50.00%> (-3.14%) ⬇️
src/logging.cc 73.49% <59.37%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d09b999...4765234. Read the comment docs.

@sergiud sergiud merged commit dfb9ffc into master Dec 15, 2021
@sergiud sergiud deleted the log-message-time-compat branch December 15, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot declare variable ‘log’ to be of abstract type ‘testing::ScopedMockLog’
3 participants